Repository navigation
fix: preserve empty GCS text artifacts - #5724
Closed
pragnyanramtha wants to merge 11 commits into
Closed
pragnyanramtha wants to merge 11 commits into
pragnyanramtha wants to merge 11 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
pragnyanramtha
marked this pull request as ready for review
May 16, 2026 21:01
Copy link
Copy Markdown
Collaborator
|
Hi @pragnyanramtha , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Hi @sasha-gitg , can you review this. LGTM. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Refreshed this branch with current main in f3e84392. Validation rerun:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Refreshed this branch with current main in 35d67347. Validation rerun:
|
Sorry, something went wrong.
copybara-service Bot
pushed a commit
that referenced
this pull request
Jun 16, 2026
Merge #5724 ## Summary - allow `GcsArtifactService` to save `Part(text="")` as a valid text artifact - load GCS blobs via `get_blob()` so missing objects are distinct from zero-byte objects - add regression coverage for saving and loading an empty GCS text artifact ## Context The file artifact backend already persists empty text artifacts, but the GCS backend checked `artifact.text` by truthiness and rejected empty strings as missing payloads. It also treated `download_as_bytes() == b""` as a missing artifact, which collapses a valid zero-byte GCS object into `None`. This keeps the existing GCS retrieval shape for text artifacts: they load as `inline_data` with `text/plain`, matching current non-empty text behavior. ## Validation - `uv run --extra test pytest tests/unittests/artifacts/test_artifact_service.py -q` -> 60 passed - `uv run --extra dev pyink --check src/google/adk/artifacts/gcs_artifact_service.py tests/unittests/artifacts/test_artifact_service.py` -> passed - `uv run --extra dev isort --check-only src/google/adk/artifacts/gcs_artifact_service.py tests/unittests/artifacts/test_artifact_service.py` -> passed - `python3 -m py_compile src/google/adk/artifacts/gcs_artifact_service.py tests/unittests/artifacts/test_artifact_service.py` -> passed - `git diff --check` -> passed Co-authored-by: Bo Yang <ybo@google.com> COPYBARA_INTEGRATE_REVIEW=#5724 from pragnyanramtha:pragnyan/gcs-empty-text-artifacts 66aba44 PiperOrigin-RevId: 932789425
Copy link
Copy Markdown
Collaborator
|
Thank you @pragnyanramtha for your contribution! 🎉 Your changes have been successfully imported and merged via Copybara in commit 8e2b06d. Closing this PR as the changes are now in the main branch. |
Sorry, something went wrong.
FrigaZzz
pushed a commit
to FrigaZzz/adk-python
that referenced
this pull request
Aug 11, 2026
Merge google#5724 ## Summary - allow `GcsArtifactService` to save `Part(text="")` as a valid text artifact - load GCS blobs via `get_blob()` so missing objects are distinct from zero-byte objects - add regression coverage for saving and loading an empty GCS text artifact ## Context The file artifact backend already persists empty text artifacts, but the GCS backend checked `artifact.text` by truthiness and rejected empty strings as missing payloads. It also treated `download_as_bytes() == b""` as a missing artifact, which collapses a valid zero-byte GCS object into `None`. This keeps the existing GCS retrieval shape for text artifacts: they load as `inline_data` with `text/plain`, matching current non-empty text behavior. ## Validation - `uv run --extra test pytest tests/unittests/artifacts/test_artifact_service.py -q` -> 60 passed - `uv run --extra dev pyink --check src/google/adk/artifacts/gcs_artifact_service.py tests/unittests/artifacts/test_artifact_service.py` -> passed - `uv run --extra dev isort --check-only src/google/adk/artifacts/gcs_artifact_service.py tests/unittests/artifacts/test_artifact_service.py` -> passed - `python3 -m py_compile src/google/adk/artifacts/gcs_artifact_service.py tests/unittests/artifacts/test_artifact_service.py` -> passed - `git diff --check` -> passed Co-authored-by: Bo Yang <ybo@google.com> COPYBARA_INTEGRATE_REVIEW=google#5724 from pragnyanramtha:pragnyan/gcs-empty-text-artifacts 66aba44 PiperOrigin-RevId: 932789425
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
The file artifact backend already persists empty text artifacts, but the GCS backend checked artifact.text by truthiness and rejected empty strings as missing payloads. It also treated download_as_bytes() == b"" as a missing artifact, which collapses a valid zero-byte GCS object into None.
This keeps the existing GCS retrieval shape for text artifacts: they load as inline_data with text/plain, matching current non-empty text behavior.
Validation