_row_to_event reads v0 event rows with raw SQL, so SQLAlchemy has no column type to coerce with and the driver's own binary representation reaches the migration. psycopg2 returns BYTEA columns as memoryview, which failed the isinstance(actions_val, bytes) check and fell into the "backend returned an object" path, so every migrated event's actions were silently replaced with an empty EventActions while the migration reported success.
The check now accepts bytes, bytearray and memoryview and coerces with bytes() before unpickling. The Spanner object path is unchanged.
Ports the parametrized regression test, which constructs each binary type in-process; on unfixed v1 the memoryview and bytearray cases fail with actions == {}.
Tested: tests/unittests/sessions/migration/test_migration.py, 36 passed on v1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports one session-migration commit to the v1 branch:
PostgreSQL binary event actions fix (e3ae4ac)
Tested: tests/unittests/sessions/migration/test_migration.py, 36 passed on v1.