Reject TAR links from untrusted archives - #5365
Open
M0nd0R wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sorry, something went wrong.
M0nd0R
force-pushed
the
agent/reject-unsafe-tar-links
branch
from
111b538 to
9bcb63c
Compare
July 15, 2026 01:14
M0nd0R
marked this pull request as ready for review
July 15, 2026 01:19
M0nd0R
force-pushed
the
agent/reject-unsafe-tar-links
branch
from
9bcb63c to
6aabbfc
Compare
July 15, 2026 01:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The path-traversal guard checked a member name but did not examine the TAR member type. A safe-looking member name could therefore create a link whose target resolved outside the extraction directory.
Impact
This prevents untrusted archive consumers, including bundled testcase processing, from later following an extracted TAR link when reading a member path.
Closes #5364
Testing