FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support quote in args-file(s) by aharonha · Pull Request #485 · google/google-java-format · GitHub

Support quote in args-file(s) - #485

Closed
aharonha wants to merge 2 commits into
google:masterfrom
aharonha:master
Closed

Support quote in args-file(s)#485
aharonha wants to merge 2 commits into
google:masterfrom
aharonha:master

Conversation

Copy link
Copy Markdown

Fixes #421
To use this feature put this in your file:

@"C:\Users\User name\git\project\filename.jar"

aharonha added 2 commits May 19, 2020 09:20
fixes google#421

arg file now supports
`@"C:\Users\User name\folder\file.java"`

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

cushon closed this Aug 11, 2021

Copy link
Copy Markdown

I just found this old PR #485 when creating a new PR for a similar topic: #931 .

Just a comment on this PR #485 here (I know it is quite old, but maybe someone reads it):
The change here solves only half of the issue, e.g., whitespaces in the parameter for the @-file itself are allowed.
However, this ignores any other parameter with whitespaces, like filenames for sourcefiles, and (from a user's perspective) it is unexpected that the quotes appear only after the @-symbol, like @"some file", and not around the complete parameter, like "@some file" or "some other param".

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fails to format files with a space in the path

4 participants


Back | FazBrowse Home | New Git URL