FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

AsyncSingletonProvider: double-checked locking pattern by hoc081098 · Pull Request #2078 · google/ground-android · GitHub

/ ground-android Public

AsyncSingletonProvider: double-checked locking pattern - #2078

Merged
gino-m merged 5 commits into
google:masterfrom
hoc081098:hoc081098-patch-1
Nov 29, 2023
ConversationCommits (5)ChecksFiles changed
Merged

AsyncSingletonProvider: double-checked locking pattern#2078
gino-m merged 5 commits into
google:masterfrom
hoc081098:hoc081098-patch-1

Conversation

hoc081098 commented Nov 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Will close #2079

  • refactor AsyncSingletonProvider: use double-checked locking pattern

hoc081098 changed the title AsyncSingletonProvider: doubled-checked locking pattern AsyncSingletonProvider: double-checked locking pattern Nov 25, 2023

gino-m commented Nov 27, 2023

Copy link
Copy Markdown
Collaborator

Thanks @hoc081098!
/gcbrun

hoc081098 commented Nov 28, 2023

Copy link
Copy Markdown
Contributor Author

@gino-m, it looks like the code does not conform the expected format.
Could you please show me the log 😇?

gino-m commented Nov 28, 2023

Copy link
Copy Markdown
Collaborator

@gino-m, it looks like the code does not conform the expected format. Could you please show me the log 😇?

Sure! It appears to be a formatting issue:

Execution failed for task ':workspace:ground:ktfmtCheckMain'.
[ktfmt] Found 1 files that are not properly formatted:
/workspace/ground/src/main/java/com/google/android/ground/util/AsyncSingletonProvider.kt

Can you try running gradle ktfmtFormat? There are a few edge cases where Android Studio ktfmt plugin doesn't apply the same rules as the Gradle ktfmt plugin.

hoc081098 commented Nov 29, 2023

Copy link
Copy Markdown
Contributor Author

@gino-m I have formatted code 🙏

gino-m commented Nov 29, 2023

Copy link
Copy Markdown
Collaborator

/gcbrun

gino-m approved these changes Nov 29, 2023
View reviewed changes

gino-m left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks for the fix!

gino-m merged commit c10c2af into google:master Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gino-m gino-m approved these changes

Assignees

No one assigned

Labels

None yet

Projects

No open projects
Ground
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor AsyncSingletonProvider to use double-checked locking.

2 participants

Back | FazBrowse Home | New Git URL