FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add doc for std.parseCsv and std.manifestCsv by rohitjangid · Pull Request #1088 · google/jsonnet · GitHub

/ jsonnet Public

feat: add doc for std.parseCsv and std.manifestCsv - #1088

Open
rohitjangid wants to merge 1 commit into
google:masterfrom
rohitjangid:feat/csv
ConversationCommits (1)ChecksFiles changed
Open

feat: add doc for std.parseCsv and std.manifestCsv#1088
rohitjangid wants to merge 1 commit into
google:masterfrom
rohitjangid:feat/csv

Conversation

rohitjangid commented May 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Add doc for std.parseCsvWithHeader and std.manifestCsv

go-jsonnet PR: google/go-jsonnet#701

rohitjangid mentioned this pull request May 25, 2023
Open

rohitjangid commented May 25, 2023

Copy link
Copy Markdown
Member Author

@sparkprime is it fine to break the compatibility for these functions in cpp implementation?

rohitjangid force-pushed the feat/csv branch 2 times, most recently from 7df78a0 to a8bebc3 Compare May 25, 2023 10:36

sparkprime commented May 25, 2023

Copy link
Copy Markdown
Contributor

Yes I think we can break compatibility for newly introduced library functions at this point.

sparkprime reviewed May 25, 2023
View reviewed changes
Comment thread doc/_stdlib_gen/stdlib-content.jsonnet Outdated
If <code>json</code> param is not a valid csv compatible object, it would be an error.
|||),
html.p({}, |||
The <code>headers</code> param adds is an optional which would default to all fields in the object.

sparkprime May 25, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It only looks at the first row, though.

rohitjangid Jun 27, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Updated

sparkprime reviewed Jun 13, 2023
View reviewed changes
Comment thread doc/_stdlib_gen/stdlib-content.jsonnet Outdated
],
},
{
name: 'parseCsv',

sparkprime Jun 13, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Needs updating to the new name

rohitjangid Jun 27, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Updated

sparkprime reviewed Jun 13, 2023
View reviewed changes
Comment thread doc/_stdlib_gen/stdlib-content.jsonnet Outdated
params: ['str', 'delimiter=","'],
availableSince: 'upcoming',
description: |||
Parses a CSV string into JSON.

sparkprime Jun 13, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Needs to mention how the first row is interpreted as a header row and must have unique column names, which then are used as fields in the JSON representation.

rohitjangid Jun 27, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Updated

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
sparkprime sparkprime left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL