Added mDeviceId to FilterAudioStream - #1310
Merged
robertwu1 merged 1 commit intoJun 16, 2021
Merged
robertwu1 merged 1 commit into
robertwu1 merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Fixed a missing parameter in FilterAudioStream. Without this change, when getDeviceId() is called, the device id is set to 0, as it uses the default value. With this change, mDeviceId correctly uses the value from the child stream. I verified that the issue repros before the change and the fix does indeed fix the problem
philburk
approved these changes
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a missing parameter in FilterAudioStream. Without this change, when getDeviceId() is called, the device id is set to 0, as it uses the default value. With this change, mDeviceId correctly uses the value from the child stream.
I verified that the issue repros before the change and the fix does indeed fix the problem