Repository navigation
Quirk: disable MMAP on SDM8150 - #1381
Merged
philburk merged 2 commits intoSep 8, 2021
Merged
philburk merged 2 commits into
philburk merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
MMAP not supported before Q. But some phones tried to use it. Fixes #1121
robertwu1
reviewed
Aug 13, 2021
Comment thread
src/common/QuirksManager.cpp
Outdated
robertwu1
approved these changes
Aug 13, 2021
Comment thread
src/common/QuirksManager.cpp
| mDeviceQuirks = std::make_unique<SamsungDeviceQuirks>(); | ||
| } else { | ||
| mDeviceQuirks = std::make_unique<DeviceQuirks>(); | ||
| std::string socManufacturer = getPropertyString("ro.soc.manufacturer"); |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
This code makes it seem that a device will is either a Samsung Device or a Qualcomm device. Would it be possible for devices to have multiple Quirks in the future?
We should worry about this later but I think the next time we add a new Quirk, like let's say for Pixel 4a, we should consider doing some refactor of this.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Good Point. We should distinguish more clearly between the Samsung Exynos quirks and the SamsungMobile quirks. They are quite different.
Sorry, something went wrong.
robertwu1
approved these changes
Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MMAP not supported before Q.
But some phones tried to use it.
Fixes #1121