OpenSL ES: Call processBufferCallback before setting the playstate to playing - #1570
Merged
robertwu1 merged 4 commits intoJul 12, 2022
Merged
robertwu1 merged 4 commits into
robertwu1 merged 4 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
philburk
suggested changes
Jun 29, 2022
Comment thread
src/opensles/AudioOutputStreamOpenSLES.cpp
Copy link
Copy Markdown
Collaborator
|
Do you also need to call requestStop_l in bqCallbackGlue? See oboe/src/opensles/AudioStreamOpenSLES.cpp Line 349 in 1e19ec7 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
Nice catch! |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Most recent commit simply caches the buffer depth as we suspect that calling setPlayState_l changes the buffer depth |
Sorry, something went wrong.
philburk
approved these changes
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1567
If processBufferCallback() is called after setPlayState_l(SL_PLAYSTATE_PLAYING), there could be cases where onAudioReady() is called from two threads.
We should not release the lock just for processBufferCallback(), so there is a minor refactor here. processBufferCallback() now returns a bool and that bool is used to determine whether requestStop_l() should be called.