Add privacy sensitive mode for API 30+ - #1751
Merged
robertwu1 merged 7 commits intoMar 24, 2023
Merged
robertwu1 merged 7 commits into
robertwu1 merged 7 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
philburk
suggested changes
Mar 16, 2023
Comment thread
include/oboe/AudioStreamBuilder.h
Outdated
Comment thread
include/oboe/Definitions.h
Outdated
Comment thread
src/aaudio/AAudioLoader.h
Comment thread
tests/testStreamOpen.cpp
Outdated
Comment thread
tests/testStreamOpen.cpp
philburk
suggested changes
Mar 16, 2023
Comment thread
tests/testStreamOpen.cpp
Outdated
philburk
suggested changes
Mar 17, 2023
Comment thread
tests/testStreamOpen.cpp
Outdated
philburk
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setPrivacySensitive/isPrivacySensitive are APIs in AAudio for overriding the default input presets. We are adding them to Oboe here.
Instead of using a boolean like in AAudio, Oboe is using a tristate of Unspecified/Enabled/Disabled. This allows a default implementation to be used and a fallback pattern for OpenSLES. Under the hood, AAudio also uses a tristate for this.
Fixes #1093