FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add IEC61937 for API 34 by robertwu1 · Pull Request #1758 · google/oboe · GitHub

/ oboe Public

Add IEC61937 for API 34 - #1758

Merged
robertwu1 merged 3 commits into
mainfrom
robertwu/addiec61937
Apr 7, 2023
ConversationCommits (3)ChecksFiles changed
Merged

Add IEC61937 for API 34 #1758
robertwu1 merged 3 commits into
mainfrom
robertwu/addiec61937

Conversation

robertwu1 commented Mar 21, 2023

Copy link
Copy Markdown
Collaborator

Fixes #1757

robertwu1 requested review from flamme and philburk March 21, 2023 23:12
robertwu1 requested a review from flamme March 21, 2023 23:39
flamme approved these changes Mar 21, 2023
View reviewed changes

flamme left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The PR looks good to me. Thanks for making the change!

philburk commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

Can this be tested?

robertwu1 commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator Author

Can this be tested?

You can test opening the stream with OboeTester.

By looking at the device report, if encoding 13 is supported, then this should open for API 34+.

philburk commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

You can test using OboeTester by selecting IEC61937
then select SampleRate=32000
then select SRC Quality::Medium
Oboe should fail on Open.

robertwu1 commented Apr 6, 2023

Copy link
Copy Markdown
Collaborator Author

You can test using OboeTester by selecting IEC61937 then select SampleRate=32000 then select SRC Quality::Medium Oboe should fail on Open.

Good test! This works for SampleRate=32000 but fails for SampleRate=96000 on the TV I tested as 32000 is supported on the TV but not 96000.

robertwu1 merged commit 8ac53b8 into main Apr 7, 2023
robertwu1 deleted the robertwu/addiec61937 branch April 7, 2023 00:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

flamme flamme approved these changes
+1 more reviewer
philburk philburk left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add IEC61937 to Oboe for API 34

3 participants

Back | FazBrowse Home | New Git URL