oboetester: try to repro routing crash - #1760
Merged
philburk merged 2 commits intoMar 30, 2023
Merged
philburk merged 2 commits into
philburk merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This test tries to trigger a routing change while long duration callbacks are playing. This can cause the callback to write into a dead buffer and cause a SIGSEGV. See b/274815060
flamme
reviewed
Mar 27, 2023
Comment thread
apps/OboeTester/app/src/main/cpp/TestRoutingCrash.cpp
Outdated
flamme
reviewed
Mar 27, 2023
Comment thread
apps/OboeTester/app/src/main/cpp/TestRoutingCrash.h
Outdated
flamme
reviewed
Mar 27, 2023
Comment thread
apps/OboeTester/app/src/main/java/com/mobileer/oboetester/TestRouteDuringCallbackActivity.java
Outdated
flamme
reviewed
Mar 27, 2023
flamme
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Thanks Phil for the PR!
The restoring the track seems pretty relies on the timing to making a crash. Is it possible to have a call from JNI to JAVA when receiving a data callback to force routing change?
Sorry, something went wrong.
robertwu1
reviewed
Mar 28, 2023
Comment thread
apps/OboeTester/app/src/main/res/layout/activity_routing_crash.xml
Outdated
Copy link
Copy Markdown
Contributor
Author
|
I could call JNI. But I can get it to crash very easily when calling getTimestamp() from the callback. |
Sorry, something went wrong.
flamme
approved these changes
Mar 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test tries to trigger a routing change
while long duration callbacks are playing.
This can cause the callback to write into a dead buffer and cause a SIGSEGV.
See b/274815060 and GitHub Issue #1763