oboe: remove OpenSL ES direct links - #2014
Merged
philburk merged 2 commits intoMay 6, 2024
Merged
philburk merged 2 commits into
philburk merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Use dlsym() to find the address of symbols like SL_IID_PLAY. This allows Oboe to be run on a device that does not have "libOpenSLES.so". This fixes b/337360630
robertwu1
approved these changes
May 3, 2024
A failure in initializing the OpenSL ES engine would call close(), which tried to lock mLock again. Use dlerror() to print info about link problems. Add a state variable for better management of the dynamic linking.
robertwu1
approved these changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use dlsym() to find the address of symbols like SL_IID_PLAY. This allows Oboe to be run on a device that does not have "libOpenSLES.so".
This fixes b/337360630