fxlab: add new icon - #2311
fxlab: add new icon#2311robertwu1 merged 3 commits into
Conversation
Sorry, something went wrong.
|
|
||
| <resources> | ||
| <string name="app_name">AndroidFX Lab</string> | ||
| <string name="app_name">fxlab</string> |
There was a problem hiding this comment.
nit, do we prefer to have first letter upper case for app name?
Sorry, something went wrong.
There was a problem hiding this comment.
not necessarily. There's other apps like soundboard that are lowercased. I prefer this to be lowercase as it's a for fun app
Sorry, something went wrong.
There was a problem hiding this comment.
There is not requirement from the development point of view as a string, it accepts both lower case and upper case letters. But from more common practice point of view, starting with upper case is more flavored. I'm also not seeing the reason of renaming here.
Sorry, something went wrong.
There was a problem hiding this comment.
The current name is so long that it goes beyond the normal viewing area of the app. This is why we should rename this.
When you open the app, the top of the app is already "fxlab". I just added a commit where we changed it to Fxlab
Sorry, something went wrong.
This PR adds a new icon for fxlab. It also changes the name of the app to fxlab from "AndroidFx Lab"