[PCM Offload] • Implement FlushFromFrame for PCM Offload - #2315
Merged
madebymozart merged 15 commits intoOct 1, 2025
Merged
madebymozart merged 15 commits into
madebymozart merged 15 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
robertwu1
reviewed
Sep 30, 2025
Comment thread
samples/iolib/src/main/cpp/player/SampleSource.h
robertwu1
reviewed
Sep 30, 2025
Comment thread
samples/powerplay/src/main/cpp/PowerPlayMultiPlayer.cpp
Outdated
flamme
reviewed
Sep 30, 2025
Comment thread
samples/iolib/src/main/cpp/player/SampleSource.h
Outdated
Comment thread
samples/iolib/src/main/cpp/player/SampleSource.h
Outdated
robertwu1
reviewed
Sep 30, 2025
Comment thread
samples/powerplay/src/main/cpp/PowerPlayMultiPlayer.cpp
Outdated
flamme
reviewed
Sep 30, 2025
Comment thread
samples/powerplay/src/main/cpp/PowerPlayMultiPlayer.cpp
Outdated
robertwu1
reviewed
Sep 30, 2025
Comment thread
samples/iolib/src/main/cpp/player/SampleSource.h
Outdated
robertwu1
reviewed
Sep 30, 2025
Comment thread
samples/powerplay/src/main/cpp/PowerPlayMultiPlayer.cpp
Outdated
flamme
reviewed
Sep 30, 2025
Comment thread
samples/powerplay/src/main/cpp/PowerPlayMultiPlayer.cpp
Outdated
flamme
reviewed
Oct 1, 2025
Comment thread
samples/powerplay/src/main/cpp/PowerPlayMultiPlayer.cpp
Outdated
Comment thread
samples/powerplay/src/main/cpp/PowerPlayMultiPlayer.cpp
Outdated
flamme
reviewed
Oct 1, 2025
Comment thread
samples/iolib/src/main/cpp/player/SampleSource.h
Outdated
robertwu1
approved these changes
Oct 1, 2025
Comment thread
samples/powerplay/src/main/cpp/PowerPlayMultiPlayer.cpp
Outdated
robertwu1
reviewed
Oct 1, 2025
Comment thread
samples/powerplay/src/main/cpp/PowerPlayMultiPlayer.cpp
| if (currentlyPlayingIndex != -1 && currentlyPlayingIndex != index) { | ||
| mSampleSources[currentlyPlayingIndex]->setStopMode(false); | ||
| } | ||
| mSampleSources[index]->setPlayMode(false); |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Just to confirm, what happens when you press pause and play and pause and play again? Does the song start from the beginning or from the position that we just paused at?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
It plays from the position that we just paused at
Sorry, something went wrong.
flamme
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements flushFromFrame when PCM offload is enabled. This allows the switching of songs as well by swiping the records at the top.
Screen_recording_20250930_141140.mp4