How often does this happen in practice? If it happens often, should we revisit how we let apps hold callbacks when the stream ends?

How often does this happen in practice? If it happens often, should we revisit how we let apps hold callbacks when the stream ends?

It is always suggested apps should call close and wait for it to return until free the shared pointer. It is not related to stream ends.

How often does this happen in practice? If it happens often, should we revisit how we let apps hold callbacks when the stream ends?

It is always suggested apps should call close and wait for it to return until free the shared pointer. It is not related to stream ends.

What happens when apps are forcefully closed? How do we handle this?

How often does this happen in practice? If it happens often, should we revisit how we let apps hold callbacks when the stream ends?

It is always suggested apps should call close and wait for it to return until free the shared pointer. It is not related to stream ends.

What happens when apps are forcefully closed? How do we handle this?

This is a different topic... Apps being forced stopping is not supposed to handle in this PR... If it is apps forcing stop, the application should have the right handle on their destroy process that will call close. If there is other reason that crashing the app and the app is not able to call close, it indicates more serious problem that is out of our scope here.

How often does this happen in practice? If it happens often, should we revisit how we let apps hold callbacks when the stream ends?

It is always suggested apps should call close and wait for it to return until free the shared pointer. It is not related to stream ends.

What happens when apps are forcefully closed? How do we handle this?

This is a different topic... Apps being forced stopping is not supposed to handle in this PR... If it is apps forcing stop, the application should have the right handle on their destroy process that will call close. If there is other reason that crashing the app and the app is not able to call close, it indicates more serious problem that is out of our scope here.

Yes, I just wanted to bring this up. The change looks good to me.