FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add A Progress Slider to PowerPlay by madebymozart · Pull Request #2345 · google/oboe · GitHub

/ oboe Public

Add A Progress Slider to PowerPlay - #2345

Merged
madebymozart merged 3 commits into
mainfrom
madebymozart/progress-slider
Mar 4, 2026
ConversationCommits (3)ChecksFiles changed
Merged

Add A Progress Slider to PowerPlay#2345
madebymozart merged 3 commits into
mainfrom
madebymozart/progress-slider

Conversation

madebymozart commented Feb 24, 2026

Copy link
Copy Markdown
Collaborator

Added a Progress Slider to PowerPlay

Note: This currently is disabled in PCM Offload Mode

madebymozart requested a review from flamme February 24, 2026 21:07
madebymozart self-assigned this Feb 24, 2026
madebymozart marked this pull request as ready for review February 24, 2026 21:07
flamme reviewed Feb 24, 2026
View reviewed changes
Comment thread samples/powerplay/src/main/cpp/PowerPlayMultiPlayer.cpp Outdated

// If offloaded, flush the stream so the seek is immediate.
if (isOffloaded()) {
mAudioStream->flush();

flamme Feb 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do you pause the stream somewhere? I think the stream is not allowed to flush when the stream is playing.

madebymozart Feb 25, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Removed as this never happens anyways

robertwu1 approved these changes Mar 3, 2026
View reviewed changes

robertwu1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Please consider whether calling getSampleBuffer is appropriate compared to adding some way to query params directly to reduce memory issues in the future

madebymozart commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator Author

@robertwu1 This is true - I might make a second PR concerning this actually - as a minor improvement

madebymozart merged commit f0207e7 into main Mar 4, 2026
3 checks passed
madebymozart deleted the madebymozart/progress-slider branch April 8, 2026 15:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

flamme flamme left review comments
robertwu1 robertwu1 approved these changes

Assignees

madebymozart

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL