Fix AAudio builder requested device id during stream open - #2353
Merged
robertwu1 merged 1 commit intoMar 19, 2026
Merged
robertwu1 merged 1 commit into
robertwu1 merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
flamme
approved these changes
Mar 19, 2026
flamme
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Thanks for the excellent debugging and fast fix!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent routing changed callback patch overrode getDeviceId() in
AudioStreamAAudio to dynamically return the mUpdatedDeviceIds array.
However, this caused a critical initialization bug.
During stream creation in AudioStreamAAudio::open(), the builder was
configured via builder_setDeviceId(aaudioBuilder, getDeviceId()). Because
mUpdatedDeviceIds is unpopulated until the very end of the open()
sequence, getDeviceId() evaluated to an empty array and prematurely
returned 0 (kUnspecified).
As a result, Oboe was completely ignoring the app's requested device
ID and strictly routing to the default microphone and speaker.
This explicitly queries AudioStreamBase::getDeviceId() during builder
initialization to correctly retrieve the app's originally requested
device ID, avoiding the overridden dynamic routing array.