oboe: add Quirk for broken mono on S9 - #890
philburk merged 4 commits into
Conversation
Sorry, something went wrong.
The Samsung S9 does not support mono properly. It is actually stereo. So on that device, we open a stereo stream and then convert it to mono by extracting the first channel. Fixes #824
This is used by the QuirksManager.
| src/flowgraph/ClipToRange.cpp | ||
| src/flowgraph/ManyToMultiConverter.cpp | ||
| src/flowgraph/MonoToMultiConverter.cpp | ||
| src/flowgraph/MultiToMonoConverter.cpp |
There was a problem hiding this comment.
Couldn't both MultiToMono and MonoToMulti be contained within single ChannelCountConverter which takes an arbitrary number of input and output channels?
Sorry, something went wrong.
There was a problem hiding this comment.
I added a ChannelCountConverter for the previous unsupported case, eg "2:3". But it looks a bit more complex and is slower than the Mono nodes. So I kept them as optimizations for the mono cases.
Sorry, something went wrong.
| ) { | ||
| // Workaround for heap size regression in O. | ||
| // b/66967812 AudioRecord does not allow FAST track for stereo capture in O | ||
| childBuilder.setChannelCount(1); |
There was a problem hiding this comment.
Constant?
Sorry, something went wrong.
dturner
left a comment
There was a problem hiding this comment.
See comments
Sorry, something went wrong.
|
|
||
| private: | ||
|
|
||
| static constexpr int32_t kChannelCountMono = 1; |
There was a problem hiding this comment.
Rather than add these I think you can use the oboe::ChannelCount::* constants
Sorry, something went wrong.
The Samsung S9 does not support mono properly.
It is actually stereo. So on that device, we open a stereo
stream and then convert it to mono by extracting
the first channel.
Fixes #824