Fix native_enum __module__ attribute: it needs to be a Python str. - #30117
Merged
rwgk merged 6 commits intoApr 19, 2024
Merged
rwgk merged 6 commits into
rwgk merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
🐍 3 • Clang dev • C++11 • x64
```
-- The CXX compiler identification is Clang 19.0.0
```
```
/__w/pybind11k/pybind11k/include/pybind11/detail/function_record_pyobject.h:38:26: error: cast from 'PyObject *(*)(PyObject *, PyObject *, PyObject *)' (aka '_object *(*)(_object *, _object *, _object *)') to 'PyCFunction' (aka '_object *(*)(_object *, _object *)') converts to incompatible function type [-Werror,-Wcast-function-type-mismatch]
38 | = {{"__reduce_ex__", (PyCFunction) reduce_ex_impl, METH_VARARGS | METH_KEYWORDS, nullptr},
```
metzen
approved these changes
Apr 19, 2024
rwgk
added a commit
to google/clif
that referenced
this pull request
Aug 27, 2024
This update needs corresponding changes in third_party/clif/testing/python/t3_test.py TGP-tested via child CL: http://tap/OCL:626240839:BASE:626375750:1713541129757:e746a257 Note: Currently codesearch finds matches for `pybind11 native_enum` only in third_party/pybind11 and third_party/clif/pybind11. This CL fixes 12 PyCLIF-pybind11 TGP failures: b/287289622#comment72 #MIGRATION_3P_PYBIND11__DEFAULT - e10cb7ec5d7091a817ed0f6a40f4d9f155c644c5 Fix `native_enum` `__module__` attribute: it needs to be ... by Ralf W. Grosse-Kunstleve <rwgk@google.com> PiperOrigin-RevId: 626400273
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a silly misunderstanding.
This PR is best understood by reviewing the individual commits in order.
Google-internal global test ID: OCL:626240839:BASE:626375750:1713541129757:e746a257
Suggested changelog entry: