| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Sorry, something went wrong.
|
I signed it! |
Sorry, something went wrong.
|
CLAs look good, thanks! |
Sorry, something went wrong.
|
This is not backwards-compatible with Python 2. Please check against file if available. Some options are mentioned here: |
Sorry, something went wrong.
|
Which method do you think is better in this case, using the tuple and try/except or checking hasattr(f, 'fileno') / hasattr(f, 'write')? |
Sorry, something went wrong.
|
I think fileno() is a good proxy because it supports file-like objects better (like sockets, etc) |
Sorry, something went wrong.
|
Coverage increased (+0.3%) to 43.893% when pulling 2ead78a on martin2250:master into d9b94b2 on google:master. |
Sorry, something went wrong.
|
Ok, the PR should be good now |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
As mentioned in #126