Refactor connection code - #57
Merged
dcbrandao merged 1 commit intoMar 19, 2019
Merged
dcbrandao merged 1 commit into
dcbrandao merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The code for managing Spanner connections is sort of clunky and I wasn't able to do things I wanted with it (the primary being you couldn't run migrations in a process that was also making active queries to the existing database), so I've split things apart a bit to make that possible. There's still some more work to allow not using global connections, but this is enough work for a PR
akefeli
approved these changes
Mar 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code for managing Spanner connections is sort of clunky and I wasn't
able to do things I wanted with it (the primary being you couldn't run
migrations in a process that was also making active queries to the
existing database), so I've split things apart a bit to make that
possible. There's still some more work to allow not using global
connections, but this is enough work for a PR
Note: Depends on #55 and #56