Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Since we're completely resetting the state of the model when we reload() it, we also need to set start_values appropriately. We ran into an issue where we were trying to roll back a change on an object, but the save() didn't cause a write to happen because the start_values had not been updated, so we thought there were no changes to commit
akefeli
approved these changes
Mar 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we're completely resetting the state of the model when we reload()
it, we also need to set start_values appropriately. We ran into an issue
where we were trying to roll back a change on an object, but the save()
didn't cause a write to happen because the start_values had not been
updated, so we thought there were no changes to commit