FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Allow custom names for indices and fields by maroux · Pull Request #76 · google/python-spanner-orm · GitHub

/ python-spanner-orm Public

Allow custom names for indices and fields - #76

Open
maroux wants to merge 2 commits into
google:mainfrom
maroux:custom_names
ConversationCommits (2)ChecksFiles changed
Open

Allow custom names for indices and fields#76
maroux wants to merge 2 commits into
google:mainfrom
maroux:custom_names

Conversation

maroux commented May 5, 2020

Copy link
Copy Markdown
Contributor
  • This allows one to name an index the same as a field like so:
class FieldCustomNameTestModel(model.Model):
  __table__ = 'FieldCustomNameTestModel'

  key = field.Field(field.String, primary_key=True)
  value = field.Field(field.String, nullable=False)

  value_idx = index.Index(['value'], name='value')

maroux added 2 commits May 5, 2020 11:43
Allow custom names for indices and fields
42bf8dc 
- This allows one to name an index the same as a field
Fixes and uniqueness test
1e8bd94

dgorelik commented Aug 12, 2020

Copy link
Copy Markdown
Contributor

Hi, sorry for a delayed review. We are now trying to make use of the Cloud Spanner Emulator for testing. Can you add some test coverage which uses the Cloud Spanner Emulator? See this example: https://github.com/google/python-spanner-orm/blob/a95d8dc9c779f0aeba6158e1f799582f1924e426/spanner_orm/tests/migrations_emulator_test.py

dgorelik self-requested a review August 12, 2020 20:56
Base automatically changed from master to main January 26, 2021 23:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dgorelik Awaiting requested review from dgorelik

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL