FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Get pytype to pass by dgorelik · Pull Request #92 · google/python-spanner-orm · GitHub

/ python-spanner-orm Public

Get pytype to pass - #92

Merged
dgorelik merged 2 commits into
masterfrom
types
Oct 6, 2020
ConversationCommits (2)ChecksFiles changed
Merged

Get pytype to pass#92
dgorelik merged 2 commits into
masterfrom
types

Conversation

dgorelik commented Oct 6, 2020

Copy link
Copy Markdown
Contributor

This PR includes the following changes to get pytype to pass at HEAD:

  • Remove ignore in relationship.py now that pytype issue #234 is fixed.
  • Switch table_apis.find and table_apis.query to return a list of sequences, and query.SpannerQuery.processResults to accept a list of sequences, so that values can be passes between those methods successfully.
  • Disable pytype with a TODO if the error was related to metaclasses or importlib.

google-cla Bot added the cla: yes label Oct 6, 2020
This was referenced Oct 6, 2020
Closed
Closed
dgorelik requested a review from dseomn October 6, 2020 18:05

dgorelik commented Oct 6, 2020

Copy link
Copy Markdown
Contributor Author

CC @supersam654

dgorelik merged commit 7db9acb into master Oct 6, 2020
dgorelik deleted the types branch October 6, 2020 18:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
dseomn dseomn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL