This repository was archived by the owner on May 29, 2026. It is now read-only.
fixed django middleware: add query to debug log correctly - #288
Open
florianschieder wants to merge 1 commit into
Open
fixed django middleware: add query to debug log correctly#288florianschieder wants to merge 1 commit into
florianschieder wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This has likely never worked correctly, as Django's query log entry has ever since been a dictionary made of 'time' and 'sql'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has likely never worked correctly, as Django's query log entry has ever since been a dictionary made of 'time' and 'sql'. I've locally mounted this sqlcommenter code state into a Django project of ours using assertNumQueries, and it worked, see output below. The queries are properly formatted into the connection debug log:
File "(...)/tests/test_dummy.py", line 7, in test_dummy with self.assertNumQueries(0): ^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/django/test/testcases.py", line 96, in __exit__ self.test_case.assertEqual( AssertionError: 2 != 0 : 2 queries executed, 0 expected Captured queries were: 1. SELECT [...] WHERE foo IN (1, 2, 3) /*controller='django_app.views.SomeView',framework='django%%3A5.0.11',route='SOME_SLUG'*/ [...]Fixes #2.