Preserve zero-valued model metrics - #9
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
@scottyak The current heads of #9 and #12 are both mergeable, all current checks are green, and there are no unresolved review threads. #9 preserves zero-valued model metrics and #12 preserves example weights in single-feature classification losses. I am grouping the request here to avoid two separate pings. Could you review them or redirect either one if needed? |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Any feedback on the zero-valued metric preservation? Please let me know if there is anything to adjust. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_model_metrics filters values by truthiness, dropping valid zero scores and errors. A zero update can also leave a previous nonzero value in the in-memory store.
Filter only None. Add classification/regression coverage across train, validation and test prefixes, plus a zero-overwrite regression.
Validation: all 11 metrics tests pass; seven new cases fail on unchanged upstream. A TensorBoard write/read check preserves zero metrics and omits missing values. Syntax and git diff --check pass.