FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use `logger.warning` instead of deprecated `warn` by zheplusplus · Pull Request #452 · googleads/googleads-python-lib · GitHub

Use logger.warning instead of deprecated warn - #452

Open
zheplusplus wants to merge 1 commit into
googleads:mainfrom
zheplusplus:master
Open

Use logger.warning instead of deprecated warn#452
zheplusplus wants to merge 1 commit into
googleads:mainfrom
zheplusplus:master

Conversation

Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Copy Markdown
Author

@googlebot I signed it!

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

lociii commented Jul 19, 2021

Copy link
Copy Markdown

Would be great if this could be merged as it's leading to a DeprecationWarning.

lociii commented Jan 10, 2022

Copy link
Copy Markdown

There are more occurrences and tests to be fixed now.
https://github.com/googleads/googleads-python-lib/search?q=logger.warn

Would be great if we could get rid of these warnings one day. Should be super easy and straight forward.

BenRKarl changed the base branch from master to main August 23, 2022 18:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL