This repository was archived by the owner on Sep 27, 2023. It is now read-only.
fix: Support delimiters(_-.~) as start or end characters for a segment. - #336
Merged
blakeli0 merged 2 commits intoFeb 4, 2022
Merged
blakeli0 merged 2 commits into
blakeli0 merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…the segment does not contain complex resource names.
vam-google
reviewed
Feb 4, 2022
Comment thread
src/main/java/com/google/api/pathtemplate/PathTemplate.java
Outdated
Comment thread
src/main/java/com/google/api/pathtemplate/PathTemplate.java
Outdated
chanseokoh
reviewed
Feb 4, 2022
Comment thread
src/main/java/com/google/api/pathtemplate/PathTemplate.java
vam-google
approved these changes
Feb 4, 2022
vam-google
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, but please check the seg.length() > 1 check comment first
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Thanks, I see what you mean now, sorry I misunderstood you earlier. On the other hand, I think the way it is now might be better since it's cleaner and easier to read. Moving seg.length() > 1 would only benefit if the segment contains one character which I think is a very rare case. |
Sorry, something went wrong.
meltsufin
approved these changes
Feb 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 more reviewers5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support delimiters(_-.~) as start or end characters for a segment if the segment does not contain complex resource names.
Fixes #335 ☕️
BEGIN_COMMIT_OVERRIDE
fix: Support delimiters(_-.~) as start or end characters for a segment
END_COMMIT_OVERRIDE