This repository was archived by the owner on Sep 27, 2023. It is now read-only.
Added transform and transformAsync overrides that accept an Executor - #38
Merged
garrettjonesgoogle merged 2 commits intoJan 17, 2018
Merged
garrettjonesgoogle merged 2 commits into
garrettjonesgoogle merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
===========================================
+ Coverage 59.23% 59.83% +0.6%
- Complexity 138 140 +2
===========================================
Files 15 15
Lines 601 610 +9
Branches 91 91
===========================================
+ Hits 356 365 +9
Misses 223 223
Partials 22 22
Continue to review full report at Codecov.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@hiranya911 add the googleJavaFormat task whenever you build to automatically fix formatting every time, for example: ./gradlew googleJavaFormat build I look forward to having tests added. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Oh wait, you already got the tests added. |
Sorry, something went wrong.
miraleung
pushed a commit
that referenced
this pull request
Jun 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods are useful when working with immediate futures and other completed futures.
I also wanted to add some tests, but cannot get past the lint errors. Every time I make the slightest change to ApiFuturesTest.java, I get:
Not helpful :(