This repository was archived by the owner on Sep 27, 2023. It is now read-only.
Add methods to ResourceName interface - #46
Merged
andreamlin merged 15 commits intoMar 6, 2018
Merged
andreamlin merged 15 commits into
andreamlin merged 15 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Blocked on googleapis/protoc-java-resource-names-plugin#28. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
PTAL |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
============================================
+ Coverage 60.23% 61.01% +0.78%
- Complexity 140 145 +5
============================================
Files 14 14
Lines 606 613 +7
Branches 91 92 +1
============================================
+ Hits 365 374 +9
+ Misses 219 215 -4
- Partials 22 24 +2
Continue to review full report at Codecov.
|
Sorry, something went wrong.
|
|
||
| @Override | ||
| /* Returns a map with an empty String as the sole key, which maps to the raw value of this ResourceName. */ | ||
| public Map<String, String> getFieldValuesMap() { |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
src/main/java/com/google/api/resourcenames/UntypedResourceName.java
Outdated
| } | ||
|
|
||
| @Override | ||
| /* Returns the raw value of this ResourceName, regardless of the fieldName parameter. */ |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
src/main/java/com/google/api/resourcenames/UntypedResourceName.java
Outdated
| /* Returns the raw value of this ResourceName iff fieldName.equals(""), else returns null. */ | ||
| @Override | ||
| public String getFieldValue(String fieldName) { | ||
| return fieldValuesMap.get(""); |
This comment was marked as spam.
This comment was marked as spam.
| } | ||
| } | ||
| return fieldValuesMap; | ||
| } |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
version.txt
Outdated
| @@ -1 +1 @@ | |||
| 1.4.0 | |||
| 1.3.1-SNAPSHOT | |||
This comment was marked as spam.
| */ | ||
| package com.google.api.resourcenames; | ||
|
|
||
| public interface ResourceNameFactory<T extends ResourceName> { |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
src/main/java/com/google/api/resourcenames/ResourceNameFactory.java
Outdated
| public interface ResourceNameFactory<T extends ResourceName> { | ||
|
|
||
| /* Create a new ResourceName from a formatted String representing a ResourceName. */ | ||
| T parseFrom(String formattedString); |
This comment was marked as spam.
This comment was marked as spam.
garrettjonesgoogle
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Ok I'm good with this PR, but we should hold off on merging until we have regenerated api-client-staging and released that code in google-cloud-java.
Sorry, something went wrong.
miraleung
pushed a commit
that referenced
this pull request
Jun 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.