FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

upgrade some deps by elharo · Pull Request #57 · googleapis/api-common-java · GitHub

This repository was archived by the owner on Sep 27, 2023. It is now read-only.
/ api-common-java Public archive

upgrade some deps - #57

Merged
garrettjonesgoogle merged 1 commit into
googleapis:masterfrom
elharo:deps
Jul 30, 2018
ConversationCommits (1)ChecksFiles changed
Merged

upgrade some deps#57
garrettjonesgoogle merged 1 commit into
googleapis:masterfrom
elharo:deps

Conversation

elharo commented Jul 13, 2018

Copy link
Copy Markdown
Contributor

Tried to upgrade guava too but that ran into issues with errorprone annotations

garrettjonesgoogle commented Jul 19, 2018

Copy link
Copy Markdown
Contributor

The Java 7 builds appear to be failing for a different reason - I filed https://github.com/googleapis/api-common-java/issues/58 to get them fixed; we should probably do that before submitting this.

garrettjonesgoogle self-requested a review July 19, 2018 17:11

elharo commented Jul 19, 2018

Copy link
Copy Markdown
Contributor Author

Makes sense

codecov-io commented Jul 30, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #57 into master will increase coverage by 0.16%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #57      +/-   ##
============================================
+ Coverage     61.01%   61.17%   +0.16%     
  Complexity      145      145              
============================================
  Files            14       14              
  Lines           613      613              
  Branches         91       92       +1     
============================================
+ Hits            374      375       +1     
  Misses          215      215              
+ Partials         24       23       -1
Impacted Files Coverage Δ Complexity Δ
...java/com/google/api/pathtemplate/PathTemplate.java 64.68% <0%> (+0.29%) 86% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7728252...476d2c0. Read the comment docs.

garrettjonesgoogle approved these changes Jul 30, 2018
View reviewed changes

garrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

garrettjonesgoogle merged commit 6f8ff7d into googleapis:master Jul 30, 2018
elharo deleted the deps branch July 30, 2018 17:54
miraleung pushed a commit that referenced this pull request Jun 4, 2020
upgrade some deps (#57)
9a3b8aa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
garrettjonesgoogle garrettjonesgoogle approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL