This repository was archived by the owner on Apr 3, 2024. It is now read-only.
fix: add timeout to firebase db connection attempt - #1132
Merged
gcf-merge-on-green[bot] merged 1 commit intoJan 16, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
mctavish
marked this pull request as ready for review
January 16, 2023 21:55
Copy link
Copy Markdown
Codecov ReportBase: 65.88% // Head: 65.68% // Decreases project coverage by -0.20% ⚠️ Additional details and impacted files @@ Coverage Diff @@
## main #1132 +/- ##
==========================================
- Coverage 65.88% 65.68% -0.21%
==========================================
Files 21 21
Lines 1791 1798 +7
Branches 355 355
==========================================
+ Hits 1180 1181 +1
- Misses 524 530 +6
Partials 87 87
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sorry, something went wrong.
jasonborg
approved these changes
Jan 16, 2023
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Jan 17, 2023
🤖 I have created a release *beep* *boop* --- ## [7.2.2](https://togithub.com/googleapis/cloud-debug-nodejs/compare/v7.2.1...v7.2.2) (2023-01-16) ### Bug Fixes * Add timeout to firebase db connection attempt ([#1132](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1132)) ([8cd89c8](https://togithub.com/googleapis/cloud-debug-nodejs/commit/8cd89c8adb33f4e3024ef6dcd79861279826aafe)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firebase database reads/writes can hang indefinitely if there is an issue with the credentials or with the database url.
Fixing firebase/firebase-admin-node#2004 will address this issue, but until then this PR adds a timeout to ensure that errors are emitted.