Tests are totally broken, who we gonna call?

@DominicKramer !

I'm not sure offhand why these are failing. I'll have to look into more detail.

@DominicKramer this looks like it's potentially surfaced an error with Istanbul, let me know when you have some time to dig in (we might need to patch something in the lcov reporter it looks like, assuming we continue getting exceptions).

@bcoe I should be able to get to this by the end of the week. I'll let you know if I need any help. Thanks.

Yes, it looks like instanbul and c8 are making semantic changes to the tests that are causing them to fail. I haven't been able to isolate exactly how.

Is there are hard requirement to switching to c8, and, if so, what is the timeline when the change is needed. Thanks.

@DominicKramer there's no hard requirement, and we can close this. But I would like to eventually figure out how V8's built in coverage is interfering with our profiling, for the benefit of the Node.js project.

c8 doesn't do anything other than setting the environment variable NODE_V8_COVERAGE, this in turn results in running Node's inspector session with slightly different configuration settings, I'm very curious how these configuration settings are interfering with this test suite.

Codecov Report

Merging #806 into master will decrease coverage by 61.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #806       +/-   ##
==========================================
- Coverage   66.00%   4.65%   -61.35%     
==========================================
  Files          20      20               
  Lines        1606    6357     +4751     
  Branches      330      21      -309     
==========================================
- Hits         1060     296      -764     
- Misses        470    6061     +5591     
+ Partials       76       0       -76     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77264fc...45b12e8. Read the comment docs.

see: https://bugs.chromium.org/p/v8/issues/detail?id=10856

@JustinBeckwith I think we can make coverage work now if we add a feature to c8 that allows us to turn it on for only certain runtimes, e.g.,

c8 --min-node-version=15

Totally your call - this is pretty low stakes :)

Cleaning up old PRs. I don't want to throw a birthday party for this thing so I'm closing it out. We can come back around in a few node versions :)