This repository was archived by the owner on Mar 26, 2026. It is now read-only.
feat: add api key support - #969
Merged
arithmetic1728 merged 3 commits intoJan 19, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
busunkim96
reviewed
Sep 7, 2021
Comment thread
gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2
Outdated
arithmetic1728
force-pushed
the
apikey
branch
from
34d6f17 to
be9da2a
Compare
September 8, 2021 01:40
arithmetic1728
force-pushed
the
apikey
branch
from
be9da2a to
9ae3e66
Compare
January 19, 2022 08:07
arithmetic1728
marked this pull request as ready for review
January 19, 2022 08:54
busunkim96
approved these changes
Jan 19, 2022
This was referenced Jan 19, 2022
This was referenced Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds API key support. Internal doc: go/gapic-api-key-support
If api_key is provided via client_options, use the api key. Note that GOOGLE_API_KEY is handled by google-auth so we don't need to do anything in microgenerator.
Related PRs:
googleapis/google-auth-library-python#826
googleapis/python-api-core#248
Tested with language api:
https://github.com/arithmetic1728/python-language/commit/da9b1215d1a46e5dc2ccc10bf9a6d1edd9cb8940