Retry and failure-handling logic for http-json by andreamlin · Pull Request #363 · googleapis/gax-java · GitHub

Exception handling and retry logic for http calls.

Blocked on #361.

… class

…managedhttpjsonchannel

Codecov Report

Merging #363 into gax-httpjson will decrease coverage by 8.92%.
The diff coverage is 95.23%.

@@                Coverage Diff                 @@
##             gax-httpjson     #363      +/-   ##
==================================================
- Coverage           76.65%   67.73%   -8.93%     
- Complexity            494      535      +41     
==================================================
  Files                 114      135      +21     
  Lines                2540     3065     +525     
  Branches              185      215      +30     
==================================================
+ Hits                 1947     2076     +129     
- Misses                522      908     +386     
- Partials               71       81      +10

Impacted Files	Coverage Δ	Complexity Δ
...le/api/gax/httpjson/HttpJsonExceptionCallable.java	90.32% <100%> (ø)	2 <0> (?)
...ogle/api/gax/httpjson/ApiResultRetryAlgorithm.java	92.85% <90%> (ø)	7 <3> (?)
.../gax/httpjson/HttpJsonAuthCallContextEnhancer.java	0% <0%> (ø)	0% <0%> (?)
...i/gax/httpjson/ApiMessageHttpRequestFormatter.java	0% <0%> (ø)	0% <0%> (?)
...httpjson/InstantiatingHttpJsonChannelProvider.java	0% <0%> (ø)	0% <0%> (?)
...om/google/api/gax/httpjson/HttpJsonStatusCode.java	66.66% <0%> (ø)	5% <0%> (?)
...x/httpjson/HttpJsonChannelCallContextEnhancer.java	0% <0%> (ø)	0% <0%> (?)
...m/google/api/gax/httpjson/HttpRequestRunnable.java	0% <0%> (ø)	0% <0%> (?)
...com/google/api/gax/httpjson/HttpJsonTransport.java	14.28% <0%> (ø)	1% <0%> (?)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e4a386...f18a013. Read the comment docs.

PTAL.

LGTM

Exception handling and retry logic for http calls.

correct license on MockHttpService remove unused de/serialization methods in ApiMethodDescriptor comments comments for MockHttpService Bootstrapping gax-httpjson (googleapis#355) Http implementation (googleapis#361) Starting implementation for HTTP/JSON. This was tested by using the surface generated from https://github.com/googleapis/toolkit/tree/discogapic to list, get, insert, and delete Compute Address resources in a live Google Cloud project. Retry and failure-handling logic for http-json (googleapis#363) Exception handling and retry logic for http calls. Merge master (googleapis#364) Merge in updates from the master branch. new HttpApiExceptionFactory that uses googleapis/rpc/code.proto to map http status codes to wrapper exception types RetryTest passes removed HttpJsonApiException.java no longer need to check status code when catching specific apiexception ??? removed unused file adding Struct class comments moving ResourceName stuff to ApiMessage pushing ResourceNameStruct into ApiMethodDescriptor and out of ApiMessage add license getFieldValue() updated remove resourcenamestruct and replace with new resourcenamefactory class; this depends on api-common PR formatting apimessage.getFieldSTringValue doesn't throw IOException ResourseNameFactory uses parse() instead of parseFrom() no need to declare throws IllegalArgumentException" setSerializer->setMethodDescriptor fix license header

andreamlin added 30 commits August 25, 2017 11:54

ApiMessage as an interface

ce8351f

comments

89dc19f

basic constructors for ApiMethodDescriptor

8480a90

adding gson to build.gradle and made ApiMethodDescriptor an AutoValue…

c8d3a88

… class

comments

c242d4c

default HttpJsonCallOptions

5423b69

using global instance of NetHttpTransport as httptransport object

d319c88

uncompileable changes to ApiMethodDescriptor

5b28bf9

uncompileable changes to ApiMethodDescriptor

f2d6e34

cleaner ApiMethodDescriptor

3ed61de

using methoddescriptor in issuing unarycall

aa219b6

managedhttpjsonchannel actually marshalls objects

63478c0

integrating ApiMessage into ManagedHttpJsonChannel

f34e3fc

made ApiMethodDescriptor AutoValue, more work in ManagedHttpJsonChannel

e5051b5

AbstractPage will turn null nextPageTokens into empty strings

a6ff124

comments

181db07

writeRequestBody writes only the body

25a4d41

apimethoddescriptor takes sets of param names

54ccd16

formatting and comments on HttpMethod

95bb1d3

requests that have non-empty bodies now work, like addresses.insert

c181a75

uncommented ApiResultRetryAlgorithm

1e1032d

s/HttpRequestBuilder/HttpRequestFormatter/g

8d3c679

moving httpTransport and httprequestfactory to be private members of …

e71074f

…managedhttpjsonchannel

adding shutdown methods to ManagedHttpJsonChannel

0a92f38

putting request body in httprequest

10da2e5

merge with origin/branch

69f076d

finally found the right maven dependency path for GoogleNetHttpTransport

e0d6c0e

betaApi

c65b1ab

another BetaApi

318abd5

creating separate class for HttpRequestRunnable

0d0c427

andreamlin added 18 commits August 25, 2017 14:33

parameterize settableapifuture

e839d03

javadoc style comments

3c6ab2f

grammar

2f52e05

removing GoogleNetHttpTransport b/c NetHttpTransport works fine

1dbaf02

using String for HttpMethod instead of something typed

d9282c1

HttpRequestRunnable is package-private

1d0e3da

private HttpRequestRunnable constructor

aeb9d59

only one try/catch block in HttpRequestRunnable.run()

d0e4323

removing HttpMethod.java

ece328d

remove ApiMethodDescriptor.toBuilder()

c68586f

default values in ApiMethodDescriptor.toBuilder()

929fd72

adding back setHttpTransport in ManagedHttpJsonChannel

6db8201

retry codes in ImmutableSet

f372174

moving RecordingScheduler to common gax-core

4dbab5d

prettying

9415291

fixed some onFailure() logic in HttpJsonExceptionCallable

0ded1f5

fixed RetryTest

6da4961

cleaning up

0a03509

andreamlin requested a review from garrettjonesgoogle August 30, 2017 23:33

Merge branch 'gax-httpjson' of github.com:googleapis/gax-java into retry

064a321

garrettjonesgoogle approved these changes Aug 31, 2017

View reviewed changes

removed finished TODO

f18a013

andreamlin merged commit 33fa52b into googleapis:gax-httpjson Aug 31, 2017

andreamlin deleted the retry branch August 31, 2017 16:41

garrettjonesgoogle pushed a commit to garrettjonesgoogle/gax-java that referenced this pull request Oct 18, 2017

Retry and failure-handling logic for http-json (googleapis#363 )

30041bf

Exception handling and retry logic for http calls.

garrettjonesgoogle pushed a commit that referenced this pull request Oct 31, 2017

Retry and failure-handling logic for http-json (#363 )

9c9ec25

Exception handling and retry logic for http calls.

garrettjonesgoogle pushed a commit that referenced this pull request Oct 31, 2017

Retry and failure-handling logic for http-json (#363 )

a7c6c97

Exception handling and retry logic for http calls.

+                    int statusCode;
+                    boolean canRetry;
+                    String message = null;
                     // TODO implement this for http-json

-                  //    }
+                  StatusCode responseCode = ((HttpJsonApiException) prevThrowable).getStatusCode();
+                  if (prevThrowable != null
+                      && responseCode.equals(HttpJsonStatusCode.of(STATUS_CODE_DEADLINE_EXCEEDED))) {

Retry and failure-handling logic for http-json by andreamlin · Pull Request #363 · googleapis/gax-java · GitHub

Retry and failure-handling logic for http-json - #363

Retry and failure-handling logic for http-json#363
andreamlin merged 50 commits into
googleapis:gax-httpjsonfrom
andreamlin:retry

andreamlin commented Aug 30, 2017 •
edited
Loading

Uh oh!

Uh oh!

codecov-io commented Aug 30, 2017 •
edited
Loading

Uh oh!

Uh oh!

andreamlin commented Aug 31, 2017

Uh oh!

garrettjonesgoogle left a comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Retry and failure-handling logic for http-json by andreamlin · Pull Request #363 · googleapis/gax-java · GitHub

Retry and failure-handling logic for http-json - #363

Retry and failure-handling logic for http-json#363andreamlin merged 50 commits intogoogleapis:gax-httpjsongoogleapis/gax-java:gax-httpjsonfrom andreamlin:retryandreamlin/gax-java:retryCopy head branch name to clipboard

Conversation

andreamlin commented Aug 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Aug 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

andreamlin commented Aug 31, 2017

Uh oh!

garrettjonesgoogle left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Retry and failure-handling logic for http-json#363
andreamlin merged 50 commits into
googleapis:gax-httpjsonfrom
andreamlin:retry

andreamlin commented Aug 30, 2017 •
edited
Loading

codecov-io commented Aug 30, 2017 •
edited
Loading