FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Also accept InputStream at setServiceAccountPrivateKeyFromP12File by kliakos · Pull Request #1011 · googleapis/google-api-java-client · GitHub

/ google-api-java-client Public

Also accept InputStream at setServiceAccountPrivateKeyFromP12File - #1011

Merged
chingor13 merged 1 commit into
googleapis:devfrom
kliakos:setServiceAccountPrivateKeyFromP12File-inputstream
Sep 13, 2018
ConversationCommits (1)ChecksFiles changed
Merged

Also accept InputStream at setServiceAccountPrivateKeyFromP12File#1011
chingor13 merged 1 commit into
googleapis:devfrom
kliakos:setServiceAccountPrivateKeyFromP12File-inputstream

Conversation

kliakos commented May 17, 2016

Copy link
Copy Markdown
Contributor

In order to overcome problems when running from inside jar.

googlebot commented May 17, 2016

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

kliakos commented May 17, 2016

Copy link
Copy Markdown
Contributor Author

I signed it!

googlebot commented May 17, 2016

Copy link
Copy Markdown

CLAs look good, thanks!

chingor13 requested changes Sep 12, 2018
View reviewed changes

chingor13 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Apologies for the super late review of this. We are getting back up to speed on these reviews.

This PR looks good except it's against the master branch which is not the primary branch of this repo (#1152). Please update this PR to target the dev branch.

kliakos changed the base branch from master to dev September 13, 2018 03:59

kliakos commented Sep 13, 2018

Copy link
Copy Markdown
Contributor Author

Ok, changed target branch to dev

chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2018
chingor13 merged commit 0487d59 into googleapis:dev Sep 13, 2018
chingor13 removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2018
chingor13 mentioned this pull request Sep 13, 2018
Closed
chingor13 mentioned this pull request Oct 12, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

chingor13 chingor13 approved these changes
+1 more reviewer
nbali nbali approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL