fix: update GoogleJsonError object to accomodate all fields in Invalid parameter exception - #1783
Merged
gcf-merge-on-green[bot] merged 3 commits intoMay 7, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…d parameter exception
elharo
reviewed
May 4, 2021
Comment thread
google-api-client/src/main/java/com/google/api/client/googleapis/json/GoogleJsonError.java
| } | ||
|
|
||
| public List<ParameterViolations> getParameterViolations() { | ||
| return parameterViolations; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
exposes mutable private state, needs a defensive copy
Sorry, something went wrong.
Comment thread
google-api-client/src/main/java/com/google/api/client/googleapis/json/GoogleJsonError.java
| return parameterViolations; | ||
| } | ||
|
|
||
| public void setParameterViolations(List<ParameterViolations> parameterViolations) { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
exposes mutable private state
Sorry, something went wrong.
Comment thread
google-api-client/src/main/java/com/google/api/client/googleapis/json/GoogleJsonError.java
| return details; | ||
| } | ||
|
|
||
| public void setDetails(List<Details> details) { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
exposes mutable private state
Sorry, something went wrong.
Comment thread
google-api-client/src/main/java/com/google/api/client/googleapis/json/GoogleJsonError.java
| this.message = message; | ||
| } | ||
|
|
||
| public List<Details> getDetails() { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
exposes mutable private state
Sorry, something went wrong.
elharo
approved these changes
May 7, 2021
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
May 10, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.31.5](https://www.github.com/googleapis/google-api-java-client/compare/v1.31.4...v1.31.5) (2021-05-10) ### Bug Fixes * release scripts from issuing overlapping phases ([#1769](https://www.github.com/googleapis/google-api-java-client/issues/1769)) ([3174ff9](https://www.github.com/googleapis/google-api-java-client/commit/3174ff9ddf0c7428b90bff766c6b18bf17d1feac)) * remove deprecated parent pom ([#1785](https://www.github.com/googleapis/google-api-java-client/issues/1785)) ([5da3355](https://www.github.com/googleapis/google-api-java-client/commit/5da335518ff5076ea5dd4f40fd0494330458296c)) * update GoogleJsonError object to accomodate all fields in Invalid parameter exception ([#1783](https://www.github.com/googleapis/google-api-java-client/issues/1783)) ([94c4570](https://www.github.com/googleapis/google-api-java-client/commit/94c4570e16324b4c654d4ec3f0f940926064d955)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes b/185405327
Invalid parameter error message does not contain details about which parameter is the invalid one. These fields have been added to GoogleJsonError object.