fix: add reason field to Details in GoogleJsonErrorObject - #1831
Merged
gcf-merge-on-green[bot] merged 3 commits intoJun 22, 2021
Merged
fix: add reason field to Details in GoogleJsonErrorObject#1831gcf-merge-on-green[bot] merged 3 commits into
gcf-merge-on-green[bot] merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
elharo
reviewed
Jun 19, 2021
Comment thread
google-api-client-bom/pom.xml
Outdated
Comment thread
google-api-client/pom.xml
Outdated
Comment thread
google-api-client/src/main/java/com/google/api/client/googleapis/json/GoogleJsonError.java
| } | ||
|
|
||
| public void setReason(String reason) { | ||
| this.reason = reason; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
this is supposed to be nullable?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
yes.
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Yes
Sorry, something went wrong.
Comment thread
pom.xml
Outdated
elharo
approved these changes
Jun 22, 2021
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Jun 22, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.32.0](https://www.github.com/googleapis/google-api-java-client/compare/v1.31.5...v1.32.0) (2021-06-22) ### Features * add `gcf-owl-bot[bot]` to `ignoreAuthors` ([#1813](https://www.github.com/googleapis/google-api-java-client/issues/1813)) ([56f5b8b](https://www.github.com/googleapis/google-api-java-client/commit/56f5b8be0a60cb1cf0b279743d85ef57d9aa46b6)) ### Bug Fixes * add reason field to Details in GoogleJsonErrorObject ([#1831](https://www.github.com/googleapis/google-api-java-client/issues/1831)) ([5e92b4c](https://www.github.com/googleapis/google-api-java-client/commit/5e92b4c22e0d45686a58de58977d20c96593e901)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
mdsahincox
approved these changes
Jun 22, 2021
mdsahincox
approved these changes
Jun 22, 2021
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Jun 24, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.32.1](https://www.github.com/googleapis/google-api-java-client/compare/v1.32.0...v1.32.1) (2021-06-24) ### Features * add `gcf-owl-bot[bot]` to `ignoreAuthors` ([#1813](https://www.github.com/googleapis/google-api-java-client/issues/1813)) ([56f5b8b](https://www.github.com/googleapis/google-api-java-client/commit/56f5b8be0a60cb1cf0b279743d85ef57d9aa46b6)) ### Bug Fixes * bring comment up to date with code ([#1838](https://www.github.com/googleapis/google-api-java-client/issues/1838)) ([f150c5a](https://www.github.com/googleapis/google-api-java-client/commit/f150c5aa6e2de0c6cbad7461f4b76be8e0027567)) * Update dependencies.sh to not break on mac ([#1830](https://www.github.com/googleapis/google-api-java-client/issues/1830)) ([97940b3](https://www.github.com/googleapis/google-api-java-client/commit/97940b3fd96e343df3985630398811f3c417afcc)) * add reason field to Details in GoogleJsonErrorObject ([#1831](https://www.github.com/googleapis/google-api-java-client/issues/1831)) ([5e92b4c](https://www.github.com/googleapis/google-api-java-client/commit/5e92b4c22e0d45686a58de58977d20c96593e901)) ### Dependencies * don't use sp versions in the regular release ([#1840](https://www.github.com/googleapis/google-api-java-client/issues/1840)) ([94cde71](https://www.github.com/googleapis/google-api-java-client/commit/94cde719e9ad845bcd186595e06279e2b7c19096)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewers3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes b/191502543
google-api-java-client id parsing error objects without reason field in details.
The actual error message:
{ "error": { "code": 400, "message": "The subscription is in a state that is not valid for the requested operation", "status": "FAILED_PRECONDITION", "details": [ { "@type": "type.googleapis.com/google.rpc.ErrorInfo", "reason": "ERROR_CODE_SUBSCRIPTION_BAD_STATE" } ] } }But when it get parsed through java api-client, it becomes:
{ "code" : 400, "details" : [ { "@type" : "type.googleapis.com/google.rpc.ErrorInfo" } ], "message" : "The subscription is in a state that is not valid for the requested operation", "status" : "FAILED_PRECONDITION" }