fix: don't set content-range on empty uploads - #1070
Merged
busunkim96 merged 2 commits intoOct 20, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
busunkim96
marked this pull request as ready for review
October 20, 2020 15:15
busunkim96
requested review from
a team,
arithmetic1728,
crwilcox and
software-dov
October 20, 2020 15:15
arithmetic1728
approved these changes
Oct 20, 2020
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Oct 20, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.12.4](https://www.github.com/googleapis/google-api-python-client/compare/v1.12.3...v1.12.4) (2020-10-20) ### Bug Fixes * don't set content-range on empty uploads ([#1070](https://www.github.com/googleapis/google-api-python-client/issues/1070)) ([af6035f](https://www.github.com/googleapis/google-api-python-client/commit/af6035f6754a155ee6b04bbbc5c39410c7316d6a)) ### Documentation * fix typo in oauth.md ([#1058](https://www.github.com/googleapis/google-api-python-client/issues/1058)) ([30eff9d](https://www.github.com/googleapis/google-api-python-client/commit/30eff9d8276919b8c4e50df2d3b1982594423692)) * update generated docs ([#1053](https://www.github.com/googleapis/google-api-python-client/issues/1053)) ([3e17f89](https://www.github.com/googleapis/google-api-python-client/commit/3e17f8990db54bec16c48c319072799a14f5a53f)), closes [#1049](https://www.github.com/googleapis/google-api-python-client/issues/1049) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
efiop
pushed a commit
to iterative/PyDrive2
that referenced
this pull request
Oct 22, 2020
googleapis/google-api-python-client#1070 is now merged, so we can get rid of our hack #48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #638 🦕
Setting the content-range header on an empty resumable upload results in 400 Invalid Argument. Only set the content-range if there is content. This is what the Java discovery client does (code).
TODO: