fix: remove repeated calls to self._get_reason - #1513
Merged
gcf-merge-on-green[bot] merged 1 commit intoSep 2, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
parthea
approved these changes
Sep 2, 2021
parthea
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for the fix, @dermasmid !
Sorry, something went wrong.
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Sep 2, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [2.19.1](https://www.github.com/googleapis/google-api-python-client/compare/v2.19.0...v2.19.1) (2021-09-02) ### Bug Fixes * remove repeated calls to self._get_reason ([#1513](https://www.github.com/googleapis/google-api-python-client/issues/1513)) ([d5cf4e0](https://www.github.com/googleapis/google-api-python-client/commit/d5cf4e0b1537eeafdb96ae831bbdffc5f1c6a94c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self._get_reason is being called in __init__ (#1185) , so why not save it then?
also in the __repr__ function we got the reason by calling the _get_reason function right in the beginning, but was then called again.