fix: drop support for Python 3.7-3.9 - #2770
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request drops support for Python 3.7, 3.8, and 3.9, raising the minimum supported Python version to 3.10 across configuration files, documentation, setup scripts, and tests. It also updates issue/PR assignment configurations and modernizes GCS copy commands in Kokoro scripts. The reviewer feedback highlights obsolete notes in CONTRIBUTING.rst regarding older Python 3 versions and Python 2 compatibility that should be removed or updated.
Sorry, something went wrong.
| .. note:: | ||
|
|
||
| System tests are only configured to run under Python 3.8. | ||
| System tests are only configured to run under Python 3.10. |
There was a problem hiding this comment.
Since Python 3.10 is now the minimum supported version, the note on the following line ('For expediency, we do not run them in older versions of Python 3.') is obsolete because there are no older supported versions of Python 3. Consider removing or updating that sentence to avoid confusion.
Sorry, something went wrong.
|
|
||
|
|
||
| We also explicitly decided to support Python 3 beginning with version 3.7. | ||
| We also explicitly decided to support Python 3 beginning with version 3.10. |
There was a problem hiding this comment.
Since the minimum supported Python version is now 3.10, the reasons listed below (specifically the third bullet point regarding Unicode literal support for Python 2 and Python 3 compatibility) are obsolete and no longer applicable. Consider removing or updating that bullet point to reflect modern Python 3.10+ features.
Sorry, something went wrong.
|
I ran the version scanner on this PR, once for each of Python 3.7, 3.8, 3.9. Python 3.7: Google Sheet Link (4 matches) There may be a few false positives, but I know that:
|
Sorry, something went wrong.
Drop support for Python 3.7. 3.8, and 3.9.
Fixes: #2769