FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: support reading in quotaProjectId for billing by codyoss · Pull Request #383 · googleapis/google-auth-library-java · GitHub

This repository was archived by the owner on May 12, 2026. It is now read-only.
/ google-auth-library-java Public archive

feat: support reading in quotaProjectId for billing - #383

Merged
codyoss merged 10 commits into
googleapis:masterfrom
codyoss:quota-project
Dec 13, 2019
ConversationCommits (10)ChecksFiles changed
Merged

feat: support reading in quotaProjectId for billing#383
codyoss merged 10 commits into
googleapis:masterfrom
codyoss:quota-project

Conversation

codyoss commented Dec 9, 2019

Copy link
Copy Markdown
Member

No description provided.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 9, 2019

codecov Bot commented Dec 9, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #383 into master will decrease coverage by 0.1%.
The diff coverage is 78.84%.

@@             Coverage Diff              @@
##             master     #383      +/-   ##
============================================
- Coverage     79.63%   79.53%   -0.11%     
- Complexity      389      397       +8     
============================================
  Files            27       27              
  Lines          1758     1803      +45     
  Branches        181      188       +7     
============================================
+ Hits           1400     1434      +34     
- Misses          262      269       +7     
- Partials         96      100       +4
Impacted Files Coverage Δ Complexity Δ
...p/java/com/google/auth/oauth2/UserCredentials.java 80% <75%> (-0.96%) 31 <2> (+3)
...uth/oauth2/ServiceAccountJwtAccessCredentials.java 75.32% <76.47%> (-0.2%) 38 <3> (+2)
...java/com/google/auth/oauth2/GoogleCredentials.java 61.36% <83.33%> (+3.46%) 10 <2> (+2) ⬆️
.../google/auth/oauth2/ServiceAccountCredentials.java 82.64% <84.61%> (-0.48%) 48 <5> (+1)
...tp/java/com/google/auth/oauth2/UserAuthorizer.java 77.59% <0%> (+0.12%) 20% <0%> (ø) ⬇️
...om/google/auth/appengine/AppEngineCredentials.java 75.47% <0%> (+0.96%) 16% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7267f3a...525beb8. Read the comment docs.

codyoss marked this pull request as ready for review December 9, 2019 19:35
codyoss requested review from a team and removed request for a team December 9, 2019 19:35
elharo reviewed Dec 10, 2019
View reviewed changes
Comment thread oauth2_http/java/com/google/auth/oauth2/GoogleCredentials.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/GoogleCredentials.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/UserCredentials.java Outdated
Comment thread oauth2_http/javatests/com/google/auth/oauth2/ServiceAccountCredentialsTest.java Outdated
codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 11, 2019
kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 11, 2019
codyoss requested a review from chingor13 December 11, 2019 03:23
This was referenced Dec 11, 2019
Merged
Merged
codyoss requested a review from chingor13 December 12, 2019 20:06
chingor13 suggested changes Dec 12, 2019
View reviewed changes
Comment thread oauth2_http/java/com/google/auth/oauth2/ServiceAccountJwtAccessCredentials.java Outdated
* @return New ServiceAccountJwtAcceessCredentials created from a private key.
* @throws IOException if the credential cannot be created from the private key.
*/
public static ServiceAccountJwtAccessCredentials fromPkcs8(

chingor13 Dec 12, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This one is also unnecessary

chingor13 Dec 12, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is this one actually needed?

codyoss Dec 12, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would say yes actually for this one. I moved it to package scope though as to not expose more surface to the api.

codyoss merged commit f38c3c8 into googleapis:master Dec 13, 2019
codyoss deleted the quota-project branch December 13, 2019 02:00
release-please Bot mentioned this pull request Jan 4, 2022
Closed
release-please Bot mentioned this pull request Aug 11, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
elharo elharo left review comments
chingor13 chingor13 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL