FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: prepare for v2.11.0 release by dbolduc · Pull Request #11762 · googleapis/google-cloud-cpp · GitHub

chore: prepare for v2.11.0 release - #11762

Merged
dbolduc merged 3 commits into
googleapis:mainfrom
dbolduc:changelog-v2-11-0
Jun 1, 2023
Merged

chore: prepare for v2.11.0 release#11762
dbolduc merged 3 commits into
googleapis:mainfrom
dbolduc:changelog-v2-11-0

Conversation

dbolduc commented Jun 1, 2023
edited by coryan
Loading

Copy link
Copy Markdown
Member

This change is 

scotthart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dbolduc)


CHANGELOG.md line 133 at r1 (raw file):

The following experimental libraries are now available:

- [Compute Engine API](/google/cloud/compute/README.md)

Let's wait on announcing this until next month as only one service is currently present.

Code quote:

The following experimental libraries are now available:

- [Compute Engine API](/google/cloud/compute/README.md)

dbolduc marked this pull request as ready for review June 1, 2023 15:44
dbolduc requested a review from a team June 1, 2023 15:44
Comment thread CHANGELOG.md Outdated
dbolduc force-pushed the changelog-v2-11-0 branch from bae5609 to 11154e7 Compare June 1, 2023 15:55

dbolduc left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @coryan and @scotthart)


CHANGELOG.md line 133 at r1 (raw file):

Previously, scotthart (Scott Hart) wrote…

Let's wait on announcing this until next month as only one service is currently present.

Good call. Done.


CHANGELOG.md line 153 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

I think you are missing #11754

Thanks. I forgot to rebase.

scotthart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @coryan)

dbolduc enabled auto-merge (squash) June 1, 2023 16:07

codecov Bot commented Jun 1, 2023
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (18af25f) 93.79% compared to head (11154e7) 93.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11762   +/-   ##
=======================================
  Coverage   93.79%   93.79%           
=======================================
  Files        1834     1834           
  Lines      165857   165857           
=======================================
  Hits       155562   155562           
  Misses      10295    10295           

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

dbolduc merged commit 37a0603 into googleapis:main Jun 1, 2023
dbolduc deleted the changelog-v2-11-0 branch June 1, 2023 18:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL