FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

cleanup(generator): remove unused code by dbolduc · Pull Request #14616 · googleapis/google-cloud-cpp · GitHub

/ google-cloud-cpp Public

cleanup(generator): remove unused code #14616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbolduc merged 1 commit into from
Aug 6, 2024
Conversation 1 Commits 1 Checks 0 Files changed
Merged

cleanup(generator): remove unused code #14616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .cc  (3) .h  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 0 additions & 2 deletions generator/internal/descriptor_utils.cc
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -815,8 +815,6 @@ std::map<std::string, VarsDictionary> CreateMethodVars(
for (int i = 0; i < service.method_count(); i++) {
auto const& method = *service.method(i);
VarsDictionary method_vars;
method_vars["method_return_doxygen_link"] =
FormatDoxygenLink(*method.output_type());
method_vars["idempotency"] = DefaultIdempotencyFromHttpOperation(method);
if (!idempotency_overrides.empty()) {
auto iter = idempotency_overrides.find(
Expand Down
6 changes: 0 additions & 6 deletions generator/internal/descriptor_utils.h
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,6 @@ namespace google {
namespace cloud {
namespace generator_internal {

/**
* Create a formatted doxygen link referencing the @p message_type.
*/
// TODO(#11545): relocate this function to a separate header.
std::string FormatDoxygenLink(google::protobuf::Descriptor const& message_type);

/**
* Extracts service wide substitution data required by all class generators from
* the provided descriptor.
Expand Down
8 changes: 0 additions & 8 deletions generator/internal/descriptor_utils_test.cc
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -1258,10 +1258,6 @@ INSTANTIATE_TEST_SUITE_P(
"google::protobuf::Empty"),
MethodVarsTestValues("my.service.v1.Service.Method0", "idempotency",
"kNonIdempotent"),
MethodVarsTestValues("my.service.v1.Service.Method0",
"method_return_doxygen_link",
"@googleapis_link{google::protobuf::Empty,google/"
"protobuf/well_known.proto#L5}"),
// Method1
MethodVarsTestValues("my.service.v1.Service.Method1", "method_name",
"Method1"),
Expand All @@ -1271,10 +1267,6 @@ INSTANTIATE_TEST_SUITE_P(
"my::service::v1::Bar"),
MethodVarsTestValues("my.service.v1.Service.Method1", "response_type",
"my::service::v1::Bar"),
MethodVarsTestValues("my.service.v1.Service.Method1",
"method_return_doxygen_link",
"@googleapis_link{my::service::v1::Bar,google/"
"foo/v1/service.proto#L19}"),
// Method2
MethodVarsTestValues("my.service.v1.Service.Method2",
"longrunning_metadata_type",
Expand Down
1 change: 1 addition & 0 deletions generator/internal/pagination.cc
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#include "generator/internal/pagination.h"
#include "generator/internal/codegen_utils.h"
#include "generator/internal/descriptor_utils.h"
#include "generator/internal/doxygen.h"
#include "google/cloud/internal/absl_str_cat_quiet.h"
#include "google/cloud/log.h"
#include "google/cloud/optional.h"
Expand Down
Back | FazBrowse Home | New Git URL