FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(rest): prevent libcurl callback from reading bad address by dbolduc · Pull Request #14626 · googleapis/google-cloud-cpp · GitHub

/ google-cloud-cpp Public

fix(rest): prevent libcurl callback from reading bad address - #14626

Merged
dbolduc merged 2 commits into
googleapis:v2.25.xfrom
dbolduc:my-patch
Aug 9, 2024
ConversationCommits (2)ChecksFiles changed
Merged

fix(rest): prevent libcurl callback from reading bad address#14626
dbolduc merged 2 commits into
googleapis:v2.25.xfrom
dbolduc:my-patch

Conversation

dbolduc commented Aug 9, 2024 •
edited by scotthart
Loading

Copy link
Copy Markdown
Member

Backport #14615 and #14617 to the v2.25.x branch, preparing for v2.25.1.

Description of changes from @scotthart:

For a Patch, Post, or Put request, curl_multi_perform should result in all the data from the associated WriteVector being consumed before it returns. Except in the case of a timeout, in which case we do not want libcurl to attempt to transmit the rest of the data while we read any remaining response data to populate the Status error message.

No need to update the ABI dumps as no public symbols have changed, and we only encode the major and minor versions in the inline namespace.

This change is 

dbolduc added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 9, 2024
scotthart approved these changes Aug 9, 2024
View reviewed changes

scotthart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dbolduc)

dbolduc removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 9, 2024
dbolduc marked this pull request as ready for review August 9, 2024 19:11
dbolduc requested a review from a team August 9, 2024 19:11

codecov Bot commented Aug 9, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (v2.25.x@aaf88be). Learn more about missing BASE report.

Files with missing lines Patch % Lines
google/cloud/internal/curl_impl.cc 77.77% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             v2.25.x   #14626   +/-   ##
==========================================
  Coverage           ?   93.77%           
==========================================
  Files              ?     2268           
  Lines              ?   201861           
  Branches           ?        0           
==========================================
  Hits               ?   189297           
  Misses             ?    12564           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dbolduc merged commit 567d8f2 into googleapis:v2.25.x Aug 9, 2024
dbolduc deleted the my-patch branch August 9, 2024 20:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

scotthart scotthart approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL