FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix version numbers and release dates. by coryan · Pull Request #1578 · googleapis/google-cloud-cpp · GitHub

/ google-cloud-cpp Public

Fix version numbers and release dates. - #1578

Merged
coryan merged 3 commits into
googleapis:v0.4.xfrom
coryan:v0.4.x
Dec 4, 2018
ConversationCommits (3)ChecksFiles changed
Merged

Fix version numbers and release dates.#1578
coryan merged 3 commits into
googleapis:v0.4.xfrom
coryan:v0.4.x

Conversation

coryan commented Dec 4, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

The version numbers in google/cloud/CMakeLists.txt was off by one. Also
fixed the release date in the release notes.

This change is 

Fix version numbers and release dates.
87f88c5 
The version numbers in google/cloud/CMakeLists.txt was off by one. Also
fixed the release date in the release notes.
coryan added the type: process A process-related concern. May include testing, release, or the like. label Dec 4, 2018
coryan requested review from frankyn and houglum December 4, 2018 02:28
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2018

codecov Bot commented Dec 4, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1578 into v0.4.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           v0.4.x    #1578   +/-   ##
=======================================
  Coverage   93.97%   93.97%           
=======================================
  Files         278      278           
  Lines       15398    15398           
=======================================
  Hits        14471    14471           
  Misses        927      927

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae742f...1041dd5. Read the comment docs.

coryan added kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Dec 4, 2018
coryan merged commit 6efdd7e into googleapis:v0.4.x Dec 4, 2018
coryan deleted the v0.4.x branch December 4, 2018 17:04

frankyn commented Dec 4, 2018

Copy link
Copy Markdown
Contributor

@coryan I just realized the branch was named 0.4.x but the release was set to 0.2.x. I may have missed something.

coryan commented Dec 4, 2018

Copy link
Copy Markdown
Contributor Author

We have inconsistent numbering for a while: bigtable and the release versions are in sync, but storage and common are behind. We may have to jump everything to 0.5.0 if we want them to get in sync.

frankyn commented Dec 4, 2018

Copy link
Copy Markdown
Contributor

Ah okay, that's fine unless we want to keep the releases consistent. I guess it would depend on how closely SemVer is being used for the CPP libraries, but IIRC they're not going to do that. Thanks for clarifying!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

houglum Awaiting requested review from houglum
1 more reviewer
frankyn frankyn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL