FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update release notes [skip ci] by devbww · Pull Request #3038 · googleapis/google-cloud-cpp · GitHub

/ google-cloud-cpp Public

Update release notes [skip ci] - #3038

Merged
devbww merged 2 commits into
googleapis:masterfrom
devbww:release
Sep 5, 2019
ConversationCommits (2)ChecksFiles changed
Merged

Update release notes [skip ci]#3038
devbww merged 2 commits into
googleapis:masterfrom
devbww:release

Conversation

devbww commented Sep 5, 2019 •
edited by coryan
Loading

Copy link
Copy Markdown
Contributor

I have something for every PR, so please note anything that should be removed.

This change is 

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 5, 2019
devbww requested a review from coryan September 5, 2019 02:13

codecov Bot commented Sep 5, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3038 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3038      +/-   ##
==========================================
+ Coverage      91%   91.04%   +0.04%     
==========================================
  Files         300      300              
  Lines       20300    20284      -16     
==========================================
- Hits        18474    18468       -6     
+ Misses       1826     1816      -10
Impacted Files Coverage Δ
google/cloud/bigtable/row_range.h 100% <0%> (ø) ⬆️
...gle/cloud/storage/internal/access_control_common.h 100% <0%> (ø) ⬆️
google/cloud/storage/internal/generic_request.h 86.48% <0%> (ø) ⬆️
google/cloud/storage/well_known_parameters.h 76.66% <0%> (+4.44%) ⬆️
google/cloud/storage/well_known_headers.h 92.59% <0%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8396e1d...c33165c. Read the comment docs.

coryan approved these changes Sep 5, 2019
View reviewed changes

coryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A few things that I would remove because they do not matter to users (in my opinion).

Comment thread google/cloud/README.md Outdated
Comment thread google/cloud/README.md Outdated
Comment thread google/cloud/storage/README.md Outdated
Comment thread google/cloud/storage/README.md Outdated
Comment thread google/cloud/storage/README.md Outdated
Comment thread google/cloud/storage/README.md Outdated
Comment thread google/cloud/storage/README.md Outdated
Comment thread google/cloud/storage/README.md Outdated
Comment thread google/cloud/storage/README.md Outdated
devbww commented Sep 5, 2019
View reviewed changes

devbww left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! PTAL.

coryan approved these changes Sep 5, 2019
View reviewed changes

coryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

devbww merged commit 6ebe10e into googleapis:master Sep 5, 2019
devbww deleted the release branch September 5, 2019 15:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

coryan coryan approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL