FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: update README files by scotthart · Pull Request #3251 · googleapis/google-cloud-cpp · GitHub

/ google-cloud-cpp Public

chore: update README files - #3251

Merged
scotthart merged 2 commits into
googleapis:masterfrom
scotthart:release_201911
Nov 5, 2019
ConversationCommits (2)ChecksFiles changed
Merged

chore: update README files#3251
scotthart merged 2 commits into
googleapis:masterfrom
scotthart:release_201911

Conversation

scotthart commented Nov 5, 2019 •
edited by coryan
Loading

Copy link
Copy Markdown
Member

This change is 

scotthart requested a review from coryan November 5, 2019 17:20
googlebot added cla: yes This human has signed the Contributor License Agreement. labels Nov 5, 2019
scotthart changed the title update README files chore: update README files Nov 5, 2019
coryan requested changes Nov 5, 2019
View reviewed changes

coryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @scotthart)

google/cloud/bigtable/README.md, line 44 at r1 (raw file):

## Release Notes

If you want you can create the place holder for the next release in this PR, up to you.

google/cloud/storage/README.md, line 58 at r1 (raw file):

    * Submodule builds no longer supported.
* Issue (#3016) resolved:
    * feat: implement `ComposeMany`

I think we should say more, maybe:

* feat: implement `ComposeMany` to efficiently compose more than 32 GCS objects
* feat: implement a function to delete all the objects that match a given prefix

google/cloud/storage/README.md, line 60 at r1 (raw file):

    * feat: implement `ComposeMany`
    * feat: implement deleting objects by prefix.
    * feat: implement tuple filtering.

I think this is irrelevant for our users.

codecov Bot commented Nov 5, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3251 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3251      +/-   ##
==========================================
+ Coverage   90.29%   90.31%   +0.01%     
==========================================
  Files         450      450              
  Lines       39898    39903       +5     
==========================================
+ Hits        36027    36039      +12     
+ Misses       3871     3864       -7
Impacted Files Coverage Δ
google/cloud/storage/internal/generic_request.h 92.3% <0%> (-5.13%) ⬇️
google/cloud/storage/well_known_parameters.h 72.52% <0%> (-2.2%) ⬇️
...oogle/cloud/bigtable/benchmarks/embedded_server.cc 97.7% <0%> (-1.15%) ⬇️
google/cloud/bigtable/metadata_update_policy.h 100% <0%> (ø) ⬆️
google/cloud/bigtable/app_profile_config.h 100% <0%> (ø) ⬆️
google/cloud/bigtable/mutations.h 100% <0%> (ø) ⬆️
google/cloud/storage/object_metadata.h 100% <0%> (ø) ⬆️
...ogle/cloud/storage/internal/hash_validator_impl.cc 100% <0%> (+2%) ⬆️
...le/cloud/bigtable/internal/async_retry_unary_rpc.h 88.46% <0%> (+3.84%) ⬆️
google/cloud/storage/well_known_headers.h 85.18% <0%> (+11.11%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0ba6b...8e045a0. Read the comment docs.

scotthart commented Nov 5, 2019
View reviewed changes

scotthart left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @coryan)

google/cloud/bigtable/README.md, line 44 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

If you want you can create the place holder for the next release in this PR, up to you.

Done.

google/cloud/storage/README.md, line 58 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

I think we should say more, maybe:

* feat: implement `ComposeMany` to efficiently compose more than 32 GCS objects
* feat: implement a function to delete all the objects that match a given prefix

Done.

google/cloud/storage/README.md, line 60 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

I think this is irrelevant for our users.

Done.

coryan approved these changes Nov 5, 2019
View reviewed changes

coryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

codecov Bot commented Nov 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #3251 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3251      +/-   ##
==========================================
- Coverage   90.29%   90.27%   -0.03%     
==========================================
  Files         450      450              
  Lines       39898    39906       +8     
==========================================
- Hits        36027    36026       -1     
- Misses       3871     3880       +9
Impacted Files Coverage Δ
google/cloud/storage/internal/complex_option.h 66.66% <0%> (-16.67%) ⬇️
google/cloud/storage/internal/curl_handle.h 65.62% <0%> (-12.5%) ⬇️
google/cloud/storage/well_known_headers.h 66.66% <0%> (-7.41%) ⬇️
google/cloud/storage/internal/generic_request.h 92.3% <0%> (-5.13%) ⬇️
google/cloud/storage/well_known_parameters.h 70.32% <0%> (-4.4%) ⬇️
google/cloud/bigtable/mutations.h 100% <0%> (ø) ⬆️
google/cloud/storage/object_metadata.h 100% <0%> (ø) ⬆️
...ogle/cloud/storage/internal/hash_validator_impl.cc 100% <0%> (+2%) ⬆️
...le/cloud/bigtable/internal/async_retry_unary_rpc.h 88.46% <0%> (+3.84%) ⬆️
google/cloud/storage/oauth2/credentials.h 66.66% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0ba6b...8e045a0. Read the comment docs.

1 similar comment

codecov Bot commented Nov 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #3251 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3251      +/-   ##
==========================================
- Coverage   90.29%   90.27%   -0.03%     
==========================================
  Files         450      450              
  Lines       39898    39906       +8     
==========================================
- Hits        36027    36026       -1     
- Misses       3871     3880       +9
Impacted Files Coverage Δ
google/cloud/storage/internal/complex_option.h 66.66% <0%> (-16.67%) ⬇️
google/cloud/storage/internal/curl_handle.h 65.62% <0%> (-12.5%) ⬇️
google/cloud/storage/well_known_headers.h 66.66% <0%> (-7.41%) ⬇️
google/cloud/storage/internal/generic_request.h 92.3% <0%> (-5.13%) ⬇️
google/cloud/storage/well_known_parameters.h 70.32% <0%> (-4.4%) ⬇️
google/cloud/bigtable/mutations.h 100% <0%> (ø) ⬆️
google/cloud/storage/object_metadata.h 100% <0%> (ø) ⬆️
...ogle/cloud/storage/internal/hash_validator_impl.cc 100% <0%> (+2%) ⬆️
...le/cloud/bigtable/internal/async_retry_unary_rpc.h 88.46% <0%> (+3.84%) ⬆️
google/cloud/storage/oauth2/credentials.h 66.66% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0ba6b...8e045a0. Read the comment docs.

codecov Bot commented Nov 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #3251 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3251      +/-   ##
==========================================
+ Coverage   90.29%   90.31%   +0.01%     
==========================================
  Files         450      450              
  Lines       39898    39903       +5     
==========================================
+ Hits        36027    36039      +12     
+ Misses       3871     3864       -7
Impacted Files Coverage Δ
google/cloud/storage/internal/generic_request.h 92.3% <0%> (-5.13%) ⬇️
google/cloud/storage/well_known_parameters.h 72.52% <0%> (-2.2%) ⬇️
...oogle/cloud/bigtable/benchmarks/embedded_server.cc 97.7% <0%> (-1.15%) ⬇️
google/cloud/bigtable/metadata_update_policy.h 100% <0%> (ø) ⬆️
google/cloud/bigtable/app_profile_config.h 100% <0%> (ø) ⬆️
google/cloud/bigtable/mutations.h 100% <0%> (ø) ⬆️
google/cloud/storage/object_metadata.h 100% <0%> (ø) ⬆️
...ogle/cloud/storage/internal/hash_validator_impl.cc 100% <0%> (+2%) ⬆️
...le/cloud/bigtable/internal/async_retry_unary_rpc.h 88.46% <0%> (+3.84%) ⬆️
google/cloud/storage/well_known_headers.h 85.18% <0%> (+11.11%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0ba6b...8e045a0. Read the comment docs.

3 similar comments

codecov Bot commented Nov 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #3251 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3251      +/-   ##
==========================================
+ Coverage   90.29%   90.31%   +0.01%     
==========================================
  Files         450      450              
  Lines       39898    39903       +5     
==========================================
+ Hits        36027    36039      +12     
+ Misses       3871     3864       -7
Impacted Files Coverage Δ
google/cloud/storage/internal/generic_request.h 92.3% <0%> (-5.13%) ⬇️
google/cloud/storage/well_known_parameters.h 72.52% <0%> (-2.2%) ⬇️
...oogle/cloud/bigtable/benchmarks/embedded_server.cc 97.7% <0%> (-1.15%) ⬇️
google/cloud/bigtable/metadata_update_policy.h 100% <0%> (ø) ⬆️
google/cloud/bigtable/app_profile_config.h 100% <0%> (ø) ⬆️
google/cloud/bigtable/mutations.h 100% <0%> (ø) ⬆️
google/cloud/storage/object_metadata.h 100% <0%> (ø) ⬆️
...ogle/cloud/storage/internal/hash_validator_impl.cc 100% <0%> (+2%) ⬆️
...le/cloud/bigtable/internal/async_retry_unary_rpc.h 88.46% <0%> (+3.84%) ⬆️
google/cloud/storage/well_known_headers.h 85.18% <0%> (+11.11%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0ba6b...8e045a0. Read the comment docs.

codecov Bot commented Nov 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #3251 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3251      +/-   ##
==========================================
+ Coverage   90.29%   90.31%   +0.01%     
==========================================
  Files         450      450              
  Lines       39898    39903       +5     
==========================================
+ Hits        36027    36039      +12     
+ Misses       3871     3864       -7
Impacted Files Coverage Δ
google/cloud/storage/internal/generic_request.h 92.3% <0%> (-5.13%) ⬇️
google/cloud/storage/well_known_parameters.h 72.52% <0%> (-2.2%) ⬇️
...oogle/cloud/bigtable/benchmarks/embedded_server.cc 97.7% <0%> (-1.15%) ⬇️
google/cloud/bigtable/metadata_update_policy.h 100% <0%> (ø) ⬆️
google/cloud/bigtable/app_profile_config.h 100% <0%> (ø) ⬆️
google/cloud/bigtable/mutations.h 100% <0%> (ø) ⬆️
google/cloud/storage/object_metadata.h 100% <0%> (ø) ⬆️
...ogle/cloud/storage/internal/hash_validator_impl.cc 100% <0%> (+2%) ⬆️
...le/cloud/bigtable/internal/async_retry_unary_rpc.h 88.46% <0%> (+3.84%) ⬆️
google/cloud/storage/well_known_headers.h 85.18% <0%> (+11.11%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0ba6b...8e045a0. Read the comment docs.

codecov Bot commented Nov 5, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3251 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3251      +/-   ##
==========================================
+ Coverage   90.29%   90.31%   +0.01%     
==========================================
  Files         450      450              
  Lines       39898    39903       +5     
==========================================
+ Hits        36027    36039      +12     
+ Misses       3871     3864       -7
Impacted Files Coverage Δ
google/cloud/storage/internal/generic_request.h 92.3% <0%> (-5.13%) ⬇️
google/cloud/storage/well_known_parameters.h 72.52% <0%> (-2.2%) ⬇️
...oogle/cloud/bigtable/benchmarks/embedded_server.cc 97.7% <0%> (-1.15%) ⬇️
google/cloud/bigtable/metadata_update_policy.h 100% <0%> (ø) ⬆️
google/cloud/bigtable/app_profile_config.h 100% <0%> (ø) ⬆️
google/cloud/bigtable/mutations.h 100% <0%> (ø) ⬆️
google/cloud/storage/object_metadata.h 100% <0%> (ø) ⬆️
...ogle/cloud/storage/internal/hash_validator_impl.cc 100% <0%> (+2%) ⬆️
...le/cloud/bigtable/internal/async_retry_unary_rpc.h 88.46% <0%> (+3.84%) ⬆️
google/cloud/storage/well_known_headers.h 85.18% <0%> (+11.11%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0ba6b...8e045a0. Read the comment docs.

scotthart merged commit e60c67a into googleapis:master Nov 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

coryan coryan approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL