chore: update CHANGELOGS for release by scotthart · Pull Request #3636 · googleapis/google-cloud-cpp · GitHub

This change is

Codecov Report

Merging #3636 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3636      +/-   ##
==========================================
- Coverage   92.28%   92.23%   -0.06%     
==========================================
  Files         461      464       +3     
  Lines       41565    41682     +117     
==========================================
+ Hits        38359    38446      +87     
- Misses       3206     3236      +30

Impacted Files	Coverage Δ
google/cloud/storage/internal/complex_option.h	44.44% <0%> (-55.56%)	⬇️
google/cloud/storage/oauth2/credentials.h	33.33% <0%> (-33.34%)	⬇️
google/cloud/storage/well_known_headers.h	70.83% <0%> (-29.17%)	⬇️
...gle/cloud/bigtable/testing/inprocess_data_client.h	83.33% <0%> (-16.67%)	⬇️
...oogle/cloud/bigtable/internal/unary_client_utils.h	84.37% <0%> (-15.63%)	⬇️
.../cloud/storage/internal/resumable_upload_session.h	43.75% <0%> (-14.15%)	⬇️
google/cloud/storage/internal/generic_request.h	90% <0%> (-10%)	⬇️
google/cloud/storage/well_known_parameters.h	90.32% <0%> (-9.68%)	⬇️
...ogle/cloud/storage/internal/curl_handle_factory.cc	91.56% <0%> (-3.62%)	⬇️
...gle/cloud/storage/internal/curl_download_request.h	80% <0%> (-3.34%)	⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a2001f...1e4af7c. Read the comment docs.

Please include

> **NOTICE:** This repo will soon contain the code for all the other related
`google-cloud-cpp-*` repos. As a new monorepo
([#3612](https://github.com/googleapis/google-cloud-cpp/issues/3612)), the
versioning of this repo will be changing to have a single per-repo version. See
https://github.com/googleapis/google-cloud-cpp/issues/3615 for more info.

Correction: I think we should tweak the wording a bit. So how about including the following in both bigtable/CHANGELOG.md and storage/CHANGELOG.md.

> **NOTICE:** This repo will soon contain the code for all the other related
`google-cloud-cpp-*` repos. As a new monorepo
([#3612](https://github.com/googleapis/google-cloud-cpp/issues/3612)), the
versioning of this repo will be changing to have a single per-repo version.
**The per-library version numbers will be removed in favor of the repo version.** See
https://github.com/googleapis/google-cloud-cpp/issues/3615 for more info.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @scotthart)

google/cloud/bigtable/CHANGELOG.md, line 5 at r1 (raw file):

## v1.10.x - TBD

## v1.9.x - 2020-4

s/2020-4/2020-04/

google/cloud/bigtable/CHANGELOG.md, line 8 at r1 (raw file):

* **BREAKING CHANGES**
  * fix!: moved IAM-related symbols to the correct namespace (#3453)

We may want to explain that these changes moved types from one inlined namespace to another, and therefore should be pretty harmless, something like:

* fix!: moved IAM-related symbols to the correct inlined namespace (#3453)
   Most users should not notice any difference, but those that explicitly referenced
   symbols through the `google::cloud::bigtable::v0` namespace may need to switch
   to `google::cloud::bigtable` (the recommended approach) or
  `google::cloud::bigtable::v1`. We apologize if this causes you inconvenience.

google/cloud/bigtable/CHANGELOG.md, line 11 at r1 (raw file):

* **Other Changes**
  * ci: drive Bigtable integration tests with Bazel or CTest (#3504)

I would skip this one.

google/cloud/storage/CHANGELOG.md, line 8 at r1 (raw file):

**BREAKING CHANGE**
  * fix!: moved IAM-related symbols to the correct namespace (#3453)

same suggestions as above.

google/cloud/storage/CHANGELOG.md, line 11 at r1 (raw file):

**Other Changes:**
  * ci: drive storage integration tests with Bazel/CMake (#3506)

nit: skip ci: changes

google/cloud/storage/CHANGELOG.md, line 18 at r1 (raw file):

  * feat: implement virtual hostname V4 signatures
  * feat: add configuration options to set the SSL root of trust (#3455)
  * feat(3449): add testbench README

this is just a testbench change, users should not care.

google/cloud/storage/CHANGELOG.md, line 21 at r1 (raw file):

  * doc: add doxygen comments for ParallelUploadFile (#3448)
  * feat: support x-goog-content-sha256 for V4 signed URLs (#3435)
  * feat: fix float issue and add content-length to failure case (#3445)

These next 4 are all related to the testbench, I do not think users would care.

Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @coryan and @devjgm)

google/cloud/bigtable/CHANGELOG.md, line 5 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

s/2020-4/2020-04/

Done.

google/cloud/bigtable/CHANGELOG.md, line 6 at r1 (raw file):

Previously, devjgm (Greg Miller) wrote…

Correction: I think we should tweak the wording a bit. So how about including the following in both bigtable/CHANGELOG.md and storage/CHANGELOG.md.

> **NOTICE:** This repo will soon contain the code for all the other related
`google-cloud-cpp-*` repos. As a new monorepo
([#3612](https://github.com/googleapis/google-cloud-cpp/issues/3612)), the
versioning of this repo will be changing to have a single per-repo version.
**The per-library version numbers will be removed in favor of the repo version.** See
https://github.com/googleapis/google-cloud-cpp/issues/3615 for more info.

Done.

google/cloud/bigtable/CHANGELOG.md, line 8 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

We may want to explain that these changes moved types from one inlined namespace to another, and therefore should be pretty harmless, something like:

* fix!: moved IAM-related symbols to the correct inlined namespace (#3453)
   Most users should not notice any difference, but those that explicitly referenced
   symbols through the `google::cloud::bigtable::v0` namespace may need to switch
   to `google::cloud::bigtable` (the recommended approach) or
  `google::cloud::bigtable::v1`. We apologize if this causes you inconvenience.

Done.

google/cloud/bigtable/CHANGELOG.md, line 11 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

I would skip this one.

Done.

google/cloud/storage/CHANGELOG.md, line 8 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

same suggestions as above.

Done.

google/cloud/storage/CHANGELOG.md, line 18 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

this is just a testbench change, users should not care.

Done.

google/cloud/storage/CHANGELOG.md, line 21 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

These next 4 are all related to the testbench, I do not think users would care.

Done.

LGTM

Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @devjgm and @scotthart)

google/cloud/storage/CHANGELOG.md, line 17 at r2 (raw file):

  * fix!: moved IAM-related symbols to the correct inlined namespace (#3453)
   Most users should not notice any difference, but those that explicitly referenced
   symbols through the `google::cloud::bigtable::v0` namespace may need to switch

Here the namespace is google::cloud::storage

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @coryan and @devjgm)

google/cloud/storage/CHANGELOG.md, line 17 at r2 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

Here the namespace is google::cloud::storage

Done.

Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @devjgm)

google/cloud/storage/CHANGELOG.md, line 17 at r2 (raw file):

Previously, scotthart (Scott Hart) wrote…

Done.

Thanks, sorry I neglected to mention that the first time.

chore: update CHANGELOGS for release

3edd638

scotthart requested review from coryan and devjgm April 1, 2020 17:33

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2020

devjgm reviewed Apr 1, 2020

View reviewed changes

coryan requested changes Apr 1, 2020

View reviewed changes

chore: update CHANGELOGS for release

6878bbb

scotthart commented Apr 1, 2020

View reviewed changes

devjgm approved these changes Apr 1, 2020

View reviewed changes

coryan requested changes Apr 1, 2020

View reviewed changes

update namespace

1e4af7c

scotthart commented Apr 1, 2020

View reviewed changes

coryan approved these changes Apr 1, 2020

View reviewed changes

scotthart merged commit 00adf2e into googleapis:master Apr 1, 2020

chore: update CHANGELOGS for release by scotthart · Pull Request #3636 · googleapis/google-cloud-cpp · GitHub

Uh oh!

chore: update CHANGELOGS for release - #3636

chore: update CHANGELOGS for release#3636
scotthart merged 3 commits into
googleapis:masterfrom
scotthart:release_202004

scotthart commented Apr 1, 2020 •
edited by coryan
Loading

Uh oh!

Uh oh!

codecov Bot commented Apr 1, 2020 •
edited
Loading

Uh oh!

Uh oh!

devjgm Apr 1, 2020

Uh oh!

devjgm Apr 1, 2020

Uh oh!

coryan left a comment

Uh oh!

scotthart left a comment

Uh oh!

devjgm left a comment

Uh oh!

coryan left a comment

Uh oh!

scotthart left a comment

Uh oh!

coryan left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		## v1.8.x - 2020-02
		## v1.9.x - 2020-4

chore: update CHANGELOGS for release by scotthart · Pull Request #3636 · googleapis/google-cloud-cpp · GitHub

Uh oh!

chore: update CHANGELOGS for release - #3636

chore: update CHANGELOGS for release#3636scotthart merged 3 commits intogoogleapis:mastergoogleapis/google-cloud-cpp:masterfrom scotthart:release_202004scotthart/google-cloud-cpp:release_202004Copy head branch name to clipboard

Conversation

scotthart commented Apr 1, 2020 • edited by coryan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Apr 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

devjgm Apr 1, 2020

Choose a reason for hiding this comment

Uh oh!

devjgm Apr 1, 2020

Choose a reason for hiding this comment

Uh oh!

coryan left a comment

Choose a reason for hiding this comment

Uh oh!

scotthart left a comment

Choose a reason for hiding this comment

Uh oh!

devjgm left a comment

Choose a reason for hiding this comment

Uh oh!

coryan left a comment

Choose a reason for hiding this comment

Uh oh!

scotthart left a comment

Choose a reason for hiding this comment

Uh oh!

coryan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chore: update CHANGELOGS for release#3636
scotthart merged 3 commits into
googleapis:masterfrom
scotthart:release_202004

scotthart commented Apr 1, 2020 •
edited by coryan
Loading

codecov Bot commented Apr 1, 2020 •
edited
Loading